Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhUqB-0000WC-Lz for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jul 2018 07:01:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fhUqA-0008Rc-6P for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jul 2018 07:01:06 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhUq9-0008RV-S0 for pgsql-hackers@lists.postgresql.org; Mon, 23 Jul 2018 07:01:06 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fhUq3-0003o0-1r for pgsql-hackers@postgresql.org; Mon, 23 Jul 2018 07:01:04 +0000 Received: by mail-pg1-x541.google.com with SMTP id v13-v6so11569328pgr.10 for ; Mon, 23 Jul 2018 00:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zTkdCUUWy+ITCdGwasAkAlKM9VM6fHvmS3i4o9t2bwE=; b=SUo7pUSPXfCpD8SuFpc7Zbuaqs0MdoTPYNOfdgcLQTyMoJQ7YijN76fdM+7KePGizo OOkXizV4rseQNreLRdd3zvoUNF6UbxsYVBxGCCdL0Yo9CXiQ255Yv+Fw3gTVVk7IGZHu g8bl2P+EJza22XzkasrU/5x/9P5mnFKN2O5qA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zTkdCUUWy+ITCdGwasAkAlKM9VM6fHvmS3i4o9t2bwE=; b=T6hw+LXvzxrsJVXx5c81c+Cw1JIUnAZ6jQUTnLZhHMfn0fbY8mKwihQWhcd7JCantS 7t/oKJLJusD/ZuyaQsPX6X1pxy9uvxuJlDxdtF50pPnXJAgsfjjAQ1Tfmwlol8njbK3W IJZnSXb9X4XHxmny1srTPGFqcAfmc76R0ggArj3sHY2otEX1styLLA9lBKytMMKrPKu4 nRyvrEOa1QKSDy2JczH5vVO+hcG4kcaFdZXVpWuHHMy6DZwzDIJSLGP5Ujv30wY7Q+on LPSAEu6zGE8+k4fDulxafnorYzfvu/bqihOwgu3p38AJvra0fHlH9Iy3zXjZ7bu7CoPG wMXw== X-Gm-Message-State: AOUpUlHYtSNwZe7MZY+Q3jd4Nf+W99JHSACnNhdbGVzEh89hxqPzkida 5VHui1WA2wUmax//dM4vO38Syg== X-Google-Smtp-Source: AAOMgpe3nQrH/fjOijtL+TGLZ0aIMNEfJAC7iZrmIAH5T7siCsZP0w7io3gus9v7N2deHCm0A3peMg== X-Received: by 2002:a65:5b08:: with SMTP id y8-v6mr10858097pgq.297.1532329257754; Mon, 23 Jul 2018 00:00:57 -0700 (PDT) Received: from rfd.leadboat.com (c-73-158-248-138.hsd1.ca.comcast.net. [73.158.248.138]) by smtp.gmail.com with ESMTPSA id q26-v6sm11325997pff.9.2018.07.23.00.00.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 00:00:56 -0700 (PDT) Date: Mon, 23 Jul 2018 00:00:54 -0700 From: Noah Misch To: Tom Lane Cc: Victor Wagner , pgsql-hackers Subject: Re: Non-portable shell code in pg_upgrade tap tests Message-ID: <20180723070054.GF3998719@rfd.leadboat.com> References: <20180720153820.69e9ae6c@fafnir.local.vm> <17833.1532096747@sss.pgh.pa.us> <20180720175508.07776219@fafnir.local.vm> <20015.1532099353@sss.pgh.pa.us> <20180722072904.GA3951499@rfd.leadboat.com> <6519.1532270763@sss.pgh.pa.us> <20180722173857.GA3998719@rfd.leadboat.com> <24717.1532285631@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24717.1532285631@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Sun, Jul 22, 2018 at 02:53:51PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Sun, Jul 22, 2018 at 10:46:03AM -0400, Tom Lane wrote: > >> The pg_upgrade makefile does in fact use $(SHELL), so it will default to > >> whatever shell configure used. > > > It will not, because we don't set $(SHELL) anywhere. $(SHELL) is not @SHELL@. > > In our makefiles, $(SHELL) is always /bin/sh, the GNU make default. > > Oh! Hm, I wonder whether we shouldn't do that, ie add SHELL = @SHELL@ > to Makefile.global.in. I see that as the right way forward.