Date: Thu, 26 Jul 2018 16:46:55 +0200
From: David Fetter <david@fetter.org>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>,
	Nico Williams <nico@cryptonector.com>, pgsql-hackers@postgresql.org
Subject: Re: Early WIP/PoC for inlining CTEs
Message-ID: <20180726144654.GH17411@fetter.org>
References: <87sh48ffhb.fsf@news-spur.riddles.org.uk>
 <20180725054236.GB17411@fetter.org>
 <20180725153205.GM5695@localhost>
 <877eljfhrx.fsf@news-spur.riddles.org.uk>
 <28e6f571-000e-f087-0553-c2ee41eac293@proxel.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <28e6f571-000e-f087-0553-c2ee41eac293@proxel.se>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Thu, Jul 26, 2018 at 02:51:53PM +0200, Andreas Karlsson wrote:
> On 07/25/2018 06:08 PM, Andrew Gierth wrote:
> >WITH ctename AS [[NOT] MATERIALIZED] (query)
> 
> I think "NOT MATERIALIZED" would be a bit misleading since the
> planner may choose to materialize anyway, so I suggest skipping that
> part of the syntax unless there is a really strong reason for having
> it.

If we're going to give people specific knobs to turn as part of
queries to affect query plans[1], we should think it through at a much
higher level than this.

If we're not going to do that right away, we just need to treat
instances where the wrong call was made as planner bugs and address
them at that level.

Best,
David.

[1] Not to use the word that starts with 'h' and sounds like lints http://pghintplan.osdn.jp/
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate