Date: Sun, 5 Aug 2018 02:48:48 -0700
From: Andres Freund <andres@anarazel.de>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Pluggable Storage - Andres's take
Message-ID: <20180805094848.ss2stpbe4ehyiwjw@alap3.anarazel.de>
References: <20180703070645.wchpu5muyto5n647@alap3.anarazel.de>
 <CAJrrPGeSycj+JiTZ2M+yX_z457EY3vEP0PzCdfoguO055f=5Wg@mail.gmail.com>
 <20180716133527.csbps4chmr7qsa7e@alap3.anarazel.de>
 <CAJrrPGfXGoDxZGg7oWYwr70xKx5ET+rwt3sUTGrTBimVvERgQQ@mail.gmail.com>
 <CAJrrPGeKTidwHBkT6+je89oqEXckSFB41Vg9sdfHvR9n_2jqmw@mail.gmail.com>
 <CAJrrPGf8dKPsFPgMXX3gf9eJsFKRe2qkx3wS-4rabpXBXQxSUA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAJrrPGf8dKPsFPgMXX3gf9eJsFKRe2qkx3wS-4rabpXBXQxSUA@mail.gmail.com>
Precedence: bulk

Hi,

I'm currently in the process of rebasing zheap onto the pluggable
storage work. The goal, which seems to work surprisingly well, is to
find issues that the current pluggable storage patch doesn't yet deal
with.  I plan to push a tree including a lot of fixes and improvements
soon.

On 2018-08-03 12:35:50 +1000, Haribabu Kommi wrote:
> while investing the crash, I observed that it is due to the lot of FIXME's
> in
> the code. So I just fixed minimal changes and looking into correcting
> the FIXME's first.
> 
> One thing I observed is lack relation pointer is leading to crash in the
> flow of EvalPlan* functions, because all ROW_MARK types doesn't
> contains relation pointer.
> 
> will continue to check all FIXME fixes.

Thanks.


> > - COPY's multi_insert path should probably deal with a bunch of slots,
> >   rather than forming HeapTuples
> >
> 
> Implemented supporting of slots in the copy multi insert path.

Cool. I've not yet looked at it, but I plan to do so soon.  Will have to
rebase over the other copy changes first :(


- Andres