Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fpyAl-0004u8-N8
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Aug 2018 15:57:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fpyAk-0007r8-0U
	for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Aug 2018 15:57:22 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1fpyAj-0007r1-Lh
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Aug 2018 15:57:21 +0000
Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1fpyAf-00081A-Ni
	for pgsql-hackers@lists.postgresql.org; Wed, 15 Aug 2018 15:57:21 +0000
Received: by mail-qt0-x242.google.com with SMTP id w26-v6so1697412qto.5
        for <pgsql-hackers@lists.postgresql.org>;
 Wed, 15 Aug 2018 08:57:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=LdaJC1rTgbVtYwvDpYI3SixxtD0IQUEdrfXAI50qveo=;
        b=ByhkOxGQ8I3bAXJyjQ7yS3NOTZkFi4L8CdVGd7MxID42FMzYP5IXtr3xKqway+Qa0W
         By1v+a5Q808qk88sQEtAx72RyF8ROi4QbMFN1756P3U8tb62EsjckuANQxPN0fa8F/BH
         GRpsmD9aEbZvxXImW8pyNmy5xqNSIoO07TifV6myVNuiUdc6xqat7OIoCSoHApf3e8nW
         3owe/j9TMIptc4s4QPTNy3ZvH2GyseZswMFeneo62xvg9Rkl//lcUnzIoUNac06TJugl
         YDbxk8uyEXF0fn2GZg4td1KKZGEIHpUIrUM19CB4gYANADci8E3F4KMDZN7UauyX0KOi
         9HaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=LdaJC1rTgbVtYwvDpYI3SixxtD0IQUEdrfXAI50qveo=;
        b=owuLafvh6SimJJmbUw9nMnoTIwuJg7ARczDv8Qyfygv041ISQw1kMRphVY7NaPnJFO
         LnADwhNhQggg+fkerJmMo5vkxFig/iwIDnKoIOmawxy1TGCczEbf6+A/ZY+ODCqDvWBb
         psmqGZrZ83dJsNK79jtJN0eRz/Z569Jsc+SjRARJV8pgeY3M3K2NFkKQJZ+fL2mxJ9yz
         u2QygNjs4PIW+1IFRq/y2zqGm5ISoTiOMm2g7Fkqj17mM85EljFnl9sScMyc4d+FyeMm
         VLq5tcr0oQWg09pAiNI/GC8XTayz8QNxQuCkr6ZzhjqJZ6gYuZOBffkOXeyB8d3JqS97
         yYnw==
X-Gm-Message-State: AOUpUlFDecXQ7JwvU1smqT9dAmwBht/EX15g8b7ISqyOJ1fV6xxWjdm9
	xf2XWEYVGFUUSp4+9520/qtVpw==
X-Google-Smtp-Source: 
 AA+uWPzivBEPg4lmFa5oxvlB/fGFzYQbio5XjGUVq0LOTjfw+2NEa8RH4BB/O5TmnZgu0ts9a7dZRQ==
X-Received: by 2002:a0c:aa46:: with SMTP id
 e6-v6mr23238974qvb.50.1534348635342;
        Wed, 15 Aug 2018 08:57:15 -0700 (PDT)
Received: from alvin.alvh.no-ip.org ([190.121.29.3])
        by smtp.gmail.com with ESMTPSA id
 127-v6sm14092760qkn.78.2018.08.15.08.57.14
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Wed, 15 Aug 2018 08:57:14 -0700 (PDT)
Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000)
	id 255876D8; Wed, 15 Aug 2018 12:56:43 -0300 (-03)
Date: Wed, 15 Aug 2018 12:56:43 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: C99 compliance for src/port/snprintf.c
Message-ID: <20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+TgmoaanyYh9KG49yWdhzU72Ngh7XG5Gs9rtceQfBg6WFaybA@mail.gmail.com>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2018-Aug-15, Robert Haas wrote:

> On Tue, Aug 14, 2018 at 7:28 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I'm almost tempted to think that the reasons above make this a
> > back-patchable bug fix.  Comments?
> 
> No objections to changing the behavior.  Have you checked whether
> there are any noticeable performance consequences?
> 
> Back-patching seems a bit aggressive to me considering that the danger
> is hypothetical.

That was my first thought too, and my preferred path would be to make
this master-only and only consider a backpatch later if we find some
practical reason to do so.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services