Date: Thu, 16 Aug 2018 06:59:28 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: remove ancient pre-dlopen dynloader code
Message-ID: <20180816135928.qer5o7uxyaeolzet@alap3.anarazel.de>
References: <3e3c7552-978b-486a-1a4a-326ee31d0545@2ndquadrant.com>
 <20180809123059.32g25qn7dgd33iyq@alap3.anarazel.de>
 <26726.1533823423@sss.pgh.pa.us>
 <20180816083107.2f5gxbvlsgvnuit4@alap3.anarazel.de>
 <8022.1534425734@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8022.1534425734@sss.pgh.pa.us>
Precedence: bulk

On 2018-08-16 09:22:14 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > This now generates a super nitpicky warning on at at least some linux +
> > clang configurations. I use -Weverything plus a lot of -Wno-*, and this
> > change added:
> > dynloader.c:7:4: warning: ISO C requires a translation unit to contain at least one declaration [-Wempty-translation-unit]
> 
> We've been seeing that (or equivalents) on other platforms for years,
> if not decades.  I can't get too excited about it really.

Yea, me neither.


> The lazy man's way to get rid of it would be to put something like
> "int bogus = 0;" in the empty dynloader.c files.  Better would be
> to not have the empty .c files at all, but I'm not sure how much
> we'd have to contort the Makefiles to support that.

If I had my druthers, we'd just remove all that configure magic for
selecting these files and just use ifdefs.  Personally I find it
occasionally that they're linked into place, rather than built under
their original name.

Greetings,

Andres Freund