Date: Mon, 20 Aug 2018 11:37:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE on system catalogs
Message-ID: <20180820023749.GD7403@paquier.xyz>
References: <e49f825b-fb25-0bc8-8afc-d5ad895c7975@2ndquadrant.com>
 <20180627203733.bfpibxdleimvwdg2@alap3.anarazel.de>
 <20180627230838.GI2667@paquier.xyz>
 <9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com>
 <920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="W5WqUoFLvi1M7tJE"
Content-Disposition: inline
In-Reply-To: <920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
Precedence: bulk


--W5WqUoFLvi1M7tJE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 13, 2018 at 11:05:10AM +0200, Peter Eisentraut wrote:
> After reviewing that thread, I think my patch would still be relevant.
> Because the pending proposal is to not add TOAST tables to some catalogs
> such as pg_attribute, so my original use case of allowing ALTER TABLE /
> SET on system catalogs would still be broken for those tables.

Something has happened in this area in the shape of 96cdeae, and the
following catalogs do not have toast tables: pg_class, pg_index,
pg_attribute and pg_largeobject*.  While 0001 proposed upthread is not
really relevant anymore because there is already a test to list which
catalogs do not have a toast table.  For 0002, indeed the patch is still
seems relevant.  The comment block at the beginning of
create_toast_table should be updated.  Some tests would also be nice to
have.
--
Michael

--W5WqUoFLvi1M7tJE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlt6KX0ACgkQnvQgOdby
QH3o2A/5AWv+HlSo+A5drSkc3xdPAllv1IsKQ71cLHe1ZZrKpXfTGLUL0VK0sEUb
v/1SYsDj2Q43A8oysE8u2H8ZECkjpLsb1BZerZpVqm4Ud0DPkjOT44KoSFLDHp3L
xT4RNymY1aqqoVALj7PQjc64A/u8jD2zwF6y6r5wqY5M7amWHdqgOxdZJ+razMgh
KdxDRzEPWpDqYbMh1d3FnNkNR34iUM4HkGtk0OYsmvHQ+gyiKWQWTd8KxWaVeU0u
26A4psE9ZEUdsUVX6UzBh5o5lV60J4DFs17c2BR4MjyX5xWMvm8GAvCbZwBv8VpV
sRX2+j9/wapSNeIQVapvctokrSY5luaIlw2TT9WTO+gCg/laJkQn57DNxULJrYjF
LbIUczunAP04iA3XxqkUGfn9DE6kLUcYE5QmYgcyal2qGRrUr/CSUC/7PkNyN0QJ
LBtlFH2cixnt03Z6YZERMob6ho2dI5jYpJb2bdfY5q2jOzRsTxL+h15Yp1k5MDad
d+sAdgsGfRGtw41rvU5kiyG5lflb492dtM5CTmlpmsRDuniTPXaSDpvV9w8svbH7
ZajWEccI5XAgv0ybGGoEBziSV2N+SktX9i+RmULJYouVuHId0O5SQmWmfSzq1yHi
9dzZRT2tAXjIC0EtVa07SFxheE/vs76XKQ+gwFO6E/IOBcPOTiU=
=65Ox
-----END PGP SIGNATURE-----

--W5WqUoFLvi1M7tJE--