Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1frj2N-0002rg-57 for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Aug 2018 12:12:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1frj2L-0003JJ-9c for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Aug 2018 12:11:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1frj2J-0003JC-7y for pgsql-hackers@lists.postgresql.org; Mon, 20 Aug 2018 12:11:57 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1frj2E-00089r-Q3 for pgsql-hackers@postgresql.org; Mon, 20 Aug 2018 12:11:54 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 726C72FB; Mon, 20 Aug 2018 08:11:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 20 Aug 2018 08:11:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=YpHrSImqBryM1NGpe5H4/V3Fszw24qukYFUDvJ8zmCk=; b=sRmL2Lom fpTUEKjAdAZLnZDAPgIKPk7SpSD9dggLJ10Ys5sE1d5jN/0a/ebD+yuV0+B36kls PF5sGjQrgfMSMht4SJKyYAceKj66kivIRvR78XsXj4m9Y9IIT3bS4nGU5kIB8JF0 LoDQLzkTNncwMgpY6gCgOzlaZYu+Ieab15b26bUxnMdBkMIfpu/q1i/+94jiqOcq Hl6hb6YA1xQfzPhet4YdkkwUjvdEWkboJNloJYAQ2OolknzLFATSQsd0YMyYjeQt 0469qXeJV76+7XZ5HTAwh85VxK8f3FaY7bylT4KFcU7mtHGEN5qDcfhlUpUUNhd5 x/Cp/NGfTWMqRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=YpHrSImqBryM1NGpe5H4/V3Fszw24 qukYFUDvJ8zmCk=; b=hpWYnGr7xFyaebRniNUnBQR1ICxy4+K3yO+zAmr8ScO40 smKKZWzk/Jswlg8kcPwJc987dKIyQlr+kU6GpQHxNa0EwiABNJyy/IjAB0ojFNXO Y5YOc6qheLdcOgLtHCFNFduu/L2WQai+035o8FOEOXAD6dvjxPGTKKP2DHZsYy8C vYNKOWzk/vz3pg25GXFlsa4CrwSOUNASFtXv1cNFO+Csq9xGTU3+G8SrlK7xI/F/ YbKVBvRj0JuzUecKlbg3de+QAIA3tNKAzQn8rEbvqbWB8W1J2L1gpKsNiLcyRDPR G3Ti6MgRDI8B7BKEWr/2OHsF8XMxnZHWwZaOe016w== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id CA4A810269; Mon, 20 Aug 2018 08:11:45 -0400 (EDT) Date: Mon, 20 Aug 2018 21:11:36 +0900 From: Michael Paquier To: Peter Eisentraut Cc: Andres Freund , pgsql-hackers Subject: Re: ALTER TABLE on system catalogs Message-ID: <20180820121136.GA1204@paquier.xyz> References: <20180627203733.bfpibxdleimvwdg2@alap3.anarazel.de> <20180627230838.GI2667@paquier.xyz> <9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com> <920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com> <20180820023749.GD7403@paquier.xyz> <26b0015a-03c5-efcd-9b47-c5a0e0ed0832@2ndquadrant.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline In-Reply-To: <26b0015a-03c5-efcd-9b47-c5a0e0ed0832@2ndquadrant.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 20, 2018 at 12:43:20PM +0200, Peter Eisentraut wrote: > Tests would require enabling allow_system_table_mods, which is > PGC_POSTMASTER, so we couldn't do it inside the normal regression test > suite. I'm not sure setting up a whole new test suite for this is worth it. I forgot this point. Likely that's not worth it. -- Michael --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlt6r/gACgkQnvQgOdby QH1Hbg//WVP7qRe/Sa0RUWTVyVLBOg8Uo742eAQqFrH3WFQB2w4FRmKB9Oii+Sbk icowKAgjH5wxHSWjlo0rCwF1UX3uDz+Jb8yP37ZXHviwP/IWscl1XrMWI+OlhkF7 Of/84GqgKm5HsKwrbz542U3yJEVQC5MxqpfHH5EYaKumD4LBFAmtW2WwyTZdY4PG 21o8wiH3n5u4Yrh3qQRpjCqehHF+yxrEAoEwpS5cjE/5WSynVW8s1YvT52mk2Wi8 OHiMzWSFW2g0yW9XhisKsM4bnvC22AU4NNuehCr5bHbw8rGDd60NhzM7K57dUcF7 gaZUpXe1UP1Xsh81lf8SCaKJpjlw/Z0iW8OKt6xt4mgAXBS8Yd6QLXTqHT9+4p7A K9QlVSE5V1XDvDFU0hEpwJo6aqXDlt6GrrTZOUwnImnRfDl3TrVuIBXRPPuHBLBk 4mHsWswQLikx7M5oFqrkypOZdf2MLqi9CfqvINLuDfin+mxU4ggBMFvzP7MugxRZ 4PaLiggT9v5jBoiLG3RkWvP9dgy43wt2R5+IkcsLEOHVXp339LvaKvyacC/0D/sz OVKLWBvDoufrYBe5jDTLbqC/t0hlvnqD92AeT3TwvX3Yd+/kd/s/PnK4EFuIVDLs uFzc3GBn0VZO3mDcppeYmLtWL6a9fUTTw971FcVJtQp+E19dAgg= =brdN -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0--