Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvQnj-0001Oc-At for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Aug 2018 17:32:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fvQng-0006oD-Pn for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Aug 2018 17:32:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvQng-0006o6-IW for pgsql-hackers@lists.postgresql.org; Thu, 30 Aug 2018 17:32:08 +0000 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fvQnd-0005PX-2P for pgsql-hackers@postgresql.org; Thu, 30 Aug 2018 17:32:08 +0000 Received: by mail-qt0-x243.google.com with SMTP id j7-v6so11257982qtp.2 for ; Thu, 30 Aug 2018 10:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=GrXWd9Rvyna+278WGbt2bpbXq+hFv4X2k+hzbxxdVcI=; b=I5igyFvYJ5nVFwoYQyh/0RqZFCvY5tDrbt7tmq17evMjFrLdb1EmoKTIOkM5UdeeaE KrTIlKHZylesthfQMsS1LI31R9Yl2Sr5dAxg1UU9rroPmJ1ep5amsRs6bzSWrVAHPRUx 0Ltj0OD0uf13i/O2IDDQj7izqmUoyqCcdTwXVcfReU/+GiF92RItXMH8RXQrr6igouaB ATHpHSv0O9aELMSSYk0kFxImz8Tr9PFGnOGBcnJgtTuMPc707LhXpQ6BnJXkpnPD7EMP wT/oAuj2WBvFsx/Z+ZK6gXxktVZOO/+c1bdn8S5mBqIswe/C4LEHIfwtIDOifNW6annP 4I4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GrXWd9Rvyna+278WGbt2bpbXq+hFv4X2k+hzbxxdVcI=; b=t/N23haH8RyIW1IJr2yCmKLSyUHi6cY2ThK1gsBHteLRCil1gpH1LvABwC7J/q+4JP dQnQsToB7LIVnp2Ig6Gwpi3oYBH8WGVt5qRCr7g+sHoiKoB/THabcABp75Y+hZdC4329 vj3Or7z8XMeeIH1pfEY/JYgnqIFViQXVCil/JGQFXb7y2C1IiJd7LPux3xqoEPmp/RPB 1c+8YvMeLpvqHhJqymcoVCQmw0rSKIA08D6oq9CSzzL8jTn5LBDgc2Bd62fvZw2DTwUA ZNushugglFgfvB6tMQB/xK1xgcMPL4NHFq0YGMsi9bgBpIz5FZq8+572WLZgK2sPxtfF Fl/A== X-Gm-Message-State: APzg51C2y35+xvPGTim00HsMaDi4AQ8Tcy/KRTGE4KzmNvf+/NTCsXJ6 Y3XqS2+8cHAqXrGCyp5Tt81M9g== X-Google-Smtp-Source: ANB0VdYC5amVyOPXMaUfwpXEA7Wmii5M8jCYw0sVuVfAtJvbcLLsgcio9kcUsRUTWfJSjpZnkAJcRw== X-Received: by 2002:a37:a357:: with SMTP id m84-v6mr12380151qke.121.1535650322458; Thu, 30 Aug 2018 10:32:02 -0700 (PDT) Received: from alvin.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id w3-v6sm3832066qkd.64.2018.08.30.10.32.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 10:32:01 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id F18006EE; Thu, 30 Aug 2018 14:31:59 -0300 (-03) Date: Thu, 30 Aug 2018 14:31:59 -0300 From: Alvaro Herrera To: Ashutosh Bapat Cc: Andres Freund , pgsql-hackers , Robert Haas , Haribabu Kommi , Amit Kapila Subject: Re: TupleTableSlot abstraction Message-ID: <20180830173159.odablfoitsxa2dhw@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Man, how I dislike patches in tarballs. 0002 says: + * shouldFree is set 'true' since a tuple stored on a disk page should not be + * pfree'd. Surely you mean 'false' :-) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services