Date: Thu, 30 Aug 2018 10:56:52 -0700
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>,
	Michael Banck <michael.banck@credativ.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
Message-ID: <20180830175652.GC15446@paquier.xyz>
References: <1535618100.1286.3.camel@credativ.de>
 <alpine.DEB.2.21.1808301325070.32764@lancre>
 <7321.1535639966@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9crTWz/Z+Zyzu20v"
Content-Disposition: inline
In-Reply-To: <7321.1535639966@sss.pgh.pa.us>
Precedence: bulk


--9crTWz/Z+Zyzu20v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 30, 2018 at 10:39:26AM -0400, Tom Lane wrote:
> I rather suspect that this hasn't been tested on anything but Intel
> hardware, which is famously misalignment-tolerant.  The lack of any
> apparent regression test infrastructure for it isn't leaving a warm
> feeling about how much the buildfarm is testing it.
>=20
> (The right fix, of course, is to malloc the work buffer rather than
> put it on the stack.)

pg_upgrade/file.c is careful about that (5afcd2a), and has a comment on
the matter, as does pg_standby.c.

Now, grepping around for "BLCKSZ]", some garbage may have accumulated?
- entrySplitPage in ginentrypage.c
- rewind_copy_file_range in file.c
- _hash_alloc_buckets in hashpage.c
- pg_prewarm.c
- blinsert.c
- pg_waldump.c
- logtape.c
--
Michael

--9crTWz/Z+Zyzu20v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluIL+QACgkQnvQgOdby
QH38UQ//cXC5WtX5J5yeLOZidC3uWYlhZ+dxr5peFSpuKrhadAVl2pPXmBPNU/cw
SyZN8LP0Y+9QkhHL25rYQyde8xjSbCP5PNAReP1Bg8NluE+5YqBYLHhgq6s4bie5
/u4SoJsh/QrfdKc417bQeWq1G2nJuAPZ9+N6JE2hP4fGZe5qQcLhIHhwrPN2Sj66
qM8MAc+rja0yPIs6HLiLftWiC1beXurAq8Dm6qUfi2qbF8i4K7QiV07xLCrlzVdj
wW7quRF/qHG0GeRT7DrNB63ihwyIeYYw7FQJCl5osCUIXcVQVjdKdURR+LfpuUkp
Dm2PUZ8L4SFeuRg5OjzkyRUsOF3bqdqL/0Eb/7evVTqpCrlwv7GPWZz6AxniwOLL
egkbI01xe6rISnVXusmE4lMFFxc8cbr9V7sdxN890J9Gqe69Ix8jjwzxQuvsyIZ1
nGw2RV8Rb79qb/gp83vP9xjgdTr2XM1L1i2i95qSgmzjQZG3WaHLlEHUFI/mzfaz
Ygjc+rs+27gYbvElyAjD3AuatXCrBOXuix6Dhee/gC4m1D1UpJ8hx9sXJroBSWgr
DVYQ3KEKZpa+RJIk29E448CCdwRrX/OAHt6kh9UCxkWBclI3BtENT1Ur8OIknOru
xHrPgkSDWXHgZa8PZaQ5wCl7mxjysiki9TR+WI+6NuhHsRN+r7s=
=pgRL
-----END PGP SIGNATURE-----

--9crTWz/Z+Zyzu20v--