Date: Sat, 1 Sep 2018 16:19:00 -0700
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>,
	Michael Banck <michael.banck@credativ.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_verify_checksums and -fno-strict-aliasing
Message-ID: <20180901231900.GF5305@paquier.xyz>
References: <7321.1535639966@sss.pgh.pa.us>
 <20180830175652.GC15446@paquier.xyz>
 <12123.1535672257@sss.pgh.pa.us>
 <20180831000600.GI15446@paquier.xyz>
 <28226.1535727306@sss.pgh.pa.us>
 <21037.1535745351@sss.pgh.pa.us>
 <20180831222119.GD5305@paquier.xyz>
 <15258.1535759998@sss.pgh.pa.us>
 <20180901003303.GE5305@paquier.xyz>
 <12600.1535830330@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/i8j2F0k9BYX4qLc"
Content-Disposition: inline
In-Reply-To: <12600.1535830330@sss.pgh.pa.us>
Precedence: bulk


--/i8j2F0k9BYX4qLc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Sep 01, 2018 at 03:32:10PM -0400, Tom Lane wrote:
> Fair enough.  I renamed the types as suggested, changed a few more
> places for consistency's sake, and pushed.

Thanks!

> There still remain some places where palloc(BLCKSZ) or equivalent is used,
> but there's no matching pfree.  In a lot of them the buffer is returned
> to the caller so there's no choice.  It's likely that some are just
> leaking the storage transiently and we could convert them to using a
> PGAlignedBlock local variable, but I didn't bother trying to do the
> analysis.

At quick glance, I am not seeing anything critical.  So the result looks
good to me.
--
Michael

--/i8j2F0k9BYX4qLc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluLHmQACgkQnvQgOdby
QH0S5BAAmo6f+oiWNPq485gtkuDqg8A1EHqv04xR54RcuhavfENQ8Iq6cTCuWRfa
ttdrfna7r17SVtQVe+Luxs6jaXylJq0FajlVomaj47UEeRYI4pF/YcG6zwGPjdIT
bx7p3wsO1ZSfsXN2m14G45fuA143L1HhasWAUVIfJc8Njhd4A9R1Tw7oTIYUbhF5
wVKv8+01f9GqbdViKl7aC7cnzhBfiI2qRQ9zRbS2c4OyprA/JaphcflP3CE1vvTl
xTXNDHP+YBrZEIjBd3GWGg4f2yvhQt6hEYXegXizKr6LlXE6vPCHy+U5jsvxO5L6
pn7Pk+WG4stV9Uv0UPhH1lYPp1CsKZ/DCVyOIOnzZELNES+67WaqfEGa/FRVlWSx
sBmLhNwLvYk/N8bT6H/ajW+ImVH+WaQlflIDobEW7rMv71ls2S2k472fvngtJbEZ
e4DH4G21goT4ObRNpV+zr2q5mFojEBU2MvL15vEVqNGj/F2Ux1RmDnIY7xN7Fnes
pzFnwnP5ze2Z7XxXdqAGGIAbVV9OpHPAlnDwIhYyuVVH+FgI4uLzC5UWz+meyKyg
VCYpbLyLF8U5dcXrSUk0HhP6GOrbvyN6mvgC3vdHnyCeX562K85CWALzqqzxLPck
oCn4mEZzaX/WGnH/jBqVTxbai5FS/OWt8upIXbxRjVPxq8eJE3U=
=/fts
-----END PGP SIGNATURE-----

--/i8j2F0k9BYX4qLc--