Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fwn2l-0002lj-Nf for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Sep 2018 11:29:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fwn2i-0008Ip-36 for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Sep 2018 11:29:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fwn2h-0008Ii-Or for pgsql-hackers@lists.postgresql.org; Mon, 03 Sep 2018 11:29:15 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fwn2e-0003DJ-6Y for pgsql-hackers@postgresql.org; Mon, 03 Sep 2018 11:29:14 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id EC4C521C1CDC; Mon, 3 Sep 2018 14:29:10 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from zakirov.localdomain (gw.postgrespro.ru [93.174.131.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id C034C21C1CD9; Mon, 3 Sep 2018 14:29:10 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1535974150; bh=K5wixjCJVKbohEOjXealQi5rp9MUos18Cgv2HR7pMLI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EBsHtz9HNeY63M0deBIAQSyERIk3eS7oHkJU8E/aOCcIOnDO6q7LNfokHGJulAXjV eSPZNrOvUHMyJS+D7RPfM5U/o3YQYirsIiOFhtHE1qJZcDy8s+bI2WwVXp+VwzNA59 kSLufkFOwCKKWuASaAfBzlb5arLBsjzRPsTGRZDE= Date: Mon, 3 Sep 2018 14:29:09 +0300 From: Arthur Zakirov To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH] Tab completion for =?utf-8?Q?A?= =?utf-8?Q?LTER_DATABASE_=E2=80=A6?= SET TABLESPACE Message-ID: <20180903112908.GA2509@zakirov.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hello, On Thu, Aug 30, 2018 at 05:54:23PM +0100, Dagfinn Ilmari Mannsåker wrote: > ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > > Hi hackers, > > > > I just noticed that psql's tab completion for ALTER TABLE … SET > > TABLESPACE was treating it as any other configuration parameter and > > completing with FROM DEFAULT or TO after it, instead of a list of > > tablespaces. > > And just after hitting send, I noticed I'd typed ALTER TABLE instead of > ALTER DATABASE, including in the commit message :( > > Fixed patch attached. +1. Attached patch works nicely. It applies using "patch". -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company