Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g0IRv-0002v2-Im for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Sep 2018 03:37:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g0IRt-00017o-V1 for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Sep 2018 03:37:45 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g0IRt-00017h-KT for pgsql-hackers@lists.postgresql.org; Thu, 13 Sep 2018 03:37:45 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g0IRr-00079J-8P for pgsql-hackers@postgresql.org; Thu, 13 Sep 2018 03:37:44 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7915D21B2D; Wed, 12 Sep 2018 23:37:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 12 Sep 2018 23:37:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=FuDuR6elVVvTzHHME0TqWAJvq1zobhN6VOpFhxPTEIQ=; b=ZDmZKYat LWLm5YfRMKqmyziOsnR6LiAgGy9vFBaKz0XCh2QpaUyWk3UWn3tX1YvKWXdOMpgM DGoc3fzubPeT+poe9LCaRTHX0Ok7skxBjqJZfB80174jRQHXpQV85+KfMvkdd7a9 F5mq3mqOx6PHMQN7UAOLOwMW4qKUaicbTUKAbChwvVDJ4zcdppKzG51gZtf1YoQS R7ic1HH0O3iVohMGaJpRtS8Pgg8YqPTkfXSAZ5ucwuhgCMpveOMb4DES6HRDyCG8 Un8CqjImsPgweOWk7xpuBXceYx71Trt82nu1/uPl+YDDUAdmY8UCRd7v+At6eHRB Ik3dhnf3M4eBEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=FuDuR6elVVvTzHHME0TqWAJvq1zob hN6VOpFhxPTEIQ=; b=DwShlaidKcBGaO1jnhoM+ih60vd8sRkPHJwynihX2Kwgg mV6wh7Cw55bp69kVT+gzrTahHJxLRJ9qqIemjAzXIhu6zb3238HVynST8IOqaZv+ Q0qagHEO/3PFe1EJwHT3L5B24P1pkXGzlgQTCIHFfo7viNEpeEgNsGzguC0qTBvk 1ltPl7d2/lXqu2SWIHwTVh0CxYMQsdT/G1+f51GHxPNx5uQt7+8WG8JCQD/NQrms G7lhpTHqqoKO9hWRW9wdmROVGvwYQNrmTrTQL4kY/k0oCRoI1ogx8yM1LbUWPP0i J07zST7/qDUlmd13Tt6FN0UZshc4XM5TEcbUuPvVw== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 97B50E48FF; Wed, 12 Sep 2018 23:37:39 -0400 (EDT) Date: Thu, 13 Sep 2018 12:37:36 +0900 From: Michael Paquier To: Tom Lane Cc: Amit Langote , Rajkumar Raghuwanshi , pgsql-hackers Subject: Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT Message-ID: <20180913033736.GD3578@paquier.xyz> References: <2bf804fb-7417-4539-51c5-f6419f1e8741@lab.ntt.co.jp> <7193.1536768840@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sXc4Kmr5FA7axrvy" Content-Disposition: inline In-Reply-To: <7193.1536768840@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --sXc4Kmr5FA7axrvy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 12, 2018 at 12:14:00PM -0400, Tom Lane wrote: > I thought we had a macro or utility function somewhere that knew which > relkinds have storage, though I can't find it right now. I'd be > inclined to instantiate that if it doesn't exist, and then the code > here ought to read something like Perhaps you are thinking about heap_create() which decides if a relkind can have storage created by setting create_storage. If you introduce a new macro, I would think that refactoring as well heap.c so as it makes use of it could make sense. -- Michael --sXc4Kmr5FA7axrvy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluZ24AACgkQnvQgOdby QH2qxg//ZtsdTIE+XusKJnDKzYtTgC7lMJht+PTXuahYSLeNEwAYupSMuYXUbfr2 YvDuJVQe149o3rPvMqYBffFRNqSVEBg9L8dNRj0+R4H7WPLCUbwv7RUPTCH8lVM/ kL9JCIMil1zlOrLrG+yyfVj5+RYQu3skZiNTjtC/ZDyHrypM6Gq6C/DhDERyQYX3 AgC7E4TOdAhtwKBEmTVZhOb1Mto/vyRHJD+nu97MkYgITfy7QXWhkm3WKzR6CIiF ZDpQgVklJwAFWYcnjvrUEExrHpRh5ZUFH+1Q5VW+CvB5S1q0Udqrjg/2/1iWb3M5 NmW8AEngksf9QHBHDHrXhUMaDoLstJGFJYUDrdrpH+GmQ9bvplaFJh1EMdTJ3//W jl7BL0ZtnUw8Zf89J3nCwbhd1S3N9adDe1MEpjZm9GKIF2CHrw5eZgOfDvinIOrA r9kd60csqwpWbn3SglAOWn/gx4HU9xIjf4ph4WhPnVekfFDKDtW3OwUYICxXrNmc jp2ryNdiMMZxdDCL5lbAiIENmyDxMtj11VXdZi/Mn4ljFJTSpZDMURwYu5BKuOzK kjb8xGzoGULsv6TOKOQMqRzMBc9wxTD52GJlhy5nI668eFkRlva34ZsgYtr83NL6 Pig00fk0+kRWlA48GrY7IIpwolv7e/phNjX22cVpxBUOI7pDryY= =3jUa -----END PGP SIGNATURE----- --sXc4Kmr5FA7axrvy--