Date: Mon, 17 Sep 2018 06:42:56 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: More deficiencies in outfuncs/readfuncs processing
Message-ID: <20180917104256.GS4184@tamriel.snowman.net>
References: <17114.1537138992@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="M7XzGsxGUydJ6R3H"
Content-Disposition: inline
In-Reply-To: <17114.1537138992@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--M7XzGsxGUydJ6R3H
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Patch 0002 addresses several more-or-less-independent issues that are
> exposed by running the regression tests with patch 0001 activated:
>=20
> * Query.withCheckOptions fails to propagate through write+read, because
> it's intentionally ignored by outfuncs/readfuncs on the grounds that
> it'd always be NIL anyway in stored rules.  This seems like premature
> optimization of the worst sort, since it's not even saving very much:
> if the assumption holds, what's suppressed from a stored Query is only
> " :withCheckOptions <>", hardly a big savings.  And of course if the
> assumption ever fails to hold, it's just broken, and broken in a non
> obvious way too (you'd only notice if you expected a check option
> failure and didn't get one).  So this is pretty dumb and I think we
> ought to fix it by treating that field normally in outfuncs/readfuncs.
> That'd require a catversion bump, but we only need to do it in HEAD.
> The only plausible alternative is to change _equalQuery to ignore
> withCheckOptions, which does not sound like a good idea at all.

I'm fine with this change (as I believe I've said before...).  I agree
that it's just a minor optimization and shouldn't be an issue to remove
it.

Thanks!

Stephen

--M7XzGsxGUydJ6R3H
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJbn4UwAAoJEO1sijiDR2RVGucQALXPrgNwv+lFq+4QgSInhdfe
6CYwT6t4cnyUQUSPYloug3uL58mHovP7wEAcaMUiPFMn4zD1jrGa9pUOmvuHyRi3
V7FR99WkAK+Fl0Hsdjn1egN5t4xBJKM2Sz1vE6h3CM+w2iqLWYUVJ1nxH4exFIzM
C6w555gm0nNnQXENtNongZrfJ9maAh3MAOl4MBhvYvzwiK0LHSilX9golT+0N1xL
pOJaYdPGlrjf4RQ0pz0orMavgeal7qkizDKpko6IOFhDSOZk96ffXnr/1wWqpH4o
07pD2EPcYq9LJmitevW5URRu7P7QW6IYAW8xPklqX8+oSCEJnK4ikAnYbIWVQOfs
/PeTStyL9pkc5nYvoMv12rt5xtbQkyk4qAb9t+2744xFAiqTG/b1MKHuQUsek7Zz
5W3c1KBceHg+jf4FAmFkRGoi3EzJsbJnBLltZ3s0rSa3+IN6O8PvYmyitB6/GSF7
QpAJ93INY5DjOvcwucz0TkQ8tn9v6wz0QcyYj/aB56HhNoonkTVzInG0DGs9dsJJ
5ZRTGPVTLSZUwPuCgFDwUorgu1e4eN2M1RvmuY3tAVo17whV2m9GYSNFFiAo9CSA
wlayWQADtzTwDIO5uRNLCQw4PC5RFLLxFBn17CPZEF4NU/GfEEjd17rm3ehj4Ws5
vV5lWbQlV9DOiP5Mvz2C
=qbzi
-----END PGP SIGNATURE-----

--M7XzGsxGUydJ6R3H--