Date: Sun, 23 Sep 2018 23:32:41 -0700
From: Noah Misch <noah@leadboat.com>
To: tgl@sss.pgh.pa.us, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: robertmhaas@gmail.com, andres@2ndquadrant.com, andrew@dunslane.net,
	pgsql-hackers@postgresql.org
Subject: Re: Something fishy happening on frogmouth
Message-ID: <20180924063241.GA3873667@rfd.leadboat.com>
References: 
 <CA+Tgmoa477p+T6n5Sh_qRSvzj8TPYoJgve0tmAGt5cpLta8FSA@mail.gmail.com>
 <20180915221546.GA3159382@rfd.leadboat.com>
 <15555.1537050112@sss.pgh.pa.us>
 <20180919.130344.143733188.horiguchi.kyotaro@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180919.130344.143733188.horiguchi.kyotaro@lab.ntt.co.jp>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Wed, Sep 19, 2018 at 01:03:44PM +0900, Kyotaro HORIGUCHI wrote:
> Thank you for finding and fixing this.
> 
> At Sat, 15 Sep 2018 18:21:52 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in <15555.1537050112@sss.pgh.pa.us>
> > Noah Misch <noah@leadboat.com> writes:
> > > Usually, the first srandom() call happens early in PostmasterMain().  I plan
> > > to add one to InitStandaloneProcess(), which substitutes for several tasks
> > > otherwise done in PostmasterMain().  That seems like a good thing even if DSM
> > > weren't in the picture.  Also, initdb needs an srandom() somewhere;
> > > choose_dsm_implementation() itself seems fine.  Attached.
> > 
> > +1, but some comments would be good.

> +1, too.

Thanks for reviewing.  I pushed with some comments.