Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g5VmG-0007k5-G0 for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Sep 2018 12:52:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g5VmC-0000Ve-JK for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Sep 2018 12:52:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g5VmB-0000VX-Fq for pgsql-hackers@lists.postgresql.org; Thu, 27 Sep 2018 12:52:16 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g5Vm2-0007WD-H0 for pgsql-hackers@postgresql.org; Thu, 27 Sep 2018 12:52:13 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5666321C5C; Thu, 27 Sep 2018 08:52:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 27 Sep 2018 08:52:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=oCy8aM9WOJ0nuJkFEGDfwX982ysCbBhel3tGFOzDJZs=; b=cSCduRnN qoVxp0a3fAXI+CLGUBTcWCUDTWcwhq4IXyOVtHdehjnmh22k1j8mg2kdufcbRwyp 95cTfyBXV59H72UpGac8hEMyFhW89LWgbS+b9FjO0wAEN2W+KbsZK6XXf+Jsd6uW w9BFaoy4dNh21Hbt5NqGhu/OpkEsTmOOFKiaVrwcrwubuoVicUyYwqHtAqM9sMED HGuNUtBOBLSDsp3zjasezdWvQ56BkR3XTeR4FlcNjsg1xQz0fXU4lSuPgnLWbUAx /ufKFDy2frbL1iPvjlRgR9Ko3ifm7/mWlpHy+97PKRpxhaFWT3GmQdPK62g8jQU0 sI8b0B9J5chlww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=oCy8aM9WOJ0nuJkFEGDfwX982ysCb Bhel3tGFOzDJZs=; b=s3PBWvDcp82KrGtt6fcna+ezk15qAZ5Kbf7OuFf7w3/GJ SZ1oYJrnIqKPxbJ+I+8hnn0Y8AAWUTKQSJyqdSetRnMTYrzKV9tWVzNyJs8eLYqf sTcSvRCFP2Vni/5O6HLOQSV1J+tDPpqjZ0zk6t24C1o3xhN8qAIGOI8RXKotXt6U 6ieUrB6lKzwvake24/O2XGGnsrwAZHcOpHAXpd4MGKxO2NU7G4M6elgHsSKADy4S KtwgYSCpSuEhxWMAgDdmOQL6/sv3ejYNdJ5JOW7INkWCpV0xYEvLXfA9eWCfDB4J WV3UhjLONQGHfawr55wGNnVkjuqlLif0xGoTvQWmQ== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id F2096E4439; Thu, 27 Sep 2018 08:51:59 -0400 (EDT) Date: Thu, 27 Sep 2018 21:51:55 +0900 From: Michael Paquier To: Amit Kapila Cc: Kyotaro HORIGUCHI , Robert Haas , hlinnaka , Dilip Kumar , pgsql-hackers Subject: Re: Problem while setting the fpw with SIGHUP Message-ID: <20180927125155.GA1745@paquier.xyz> References: <20180906233728.GR2726@paquier.xyz> <20180914072655.GI29332@paquier.xyz> <20180918.161542.79085818.horiguchi.kyotaro@lab.ntt.co.jp> <20180919052034.GI1650@paquier.xyz> <20180927050440.GR1659@paquier.xyz> <20180927080221.GU1659@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 27, 2018 at 04:19:02PM +0530, Amit Kapila wrote: > I think this is mostly fine, but it seems "if the instance just got > out of recovery" doesn't fit well because it can happen anytime after > recovery, this code gets called from checkpointer. I think we can > slightly tweak it as below: > "Perform this outside critical section so that the WAL insert > initialization done by RecoveryInProgress() doesn't trigger an > assertion failure." >=20 > What do you say? Fine for me. >> Sure, feel free to if you have some room. I am fine to take care of it >> as well, so that's up to you to decide. >=20 > Okay, I will take care of it. Thanks. -- Michael --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlus0msACgkQnvQgOdby QH2DGxAAjaigAKmtQBGC97v8TXhxpT3E9N0+wGu8bPr16T9N4cI+aAED+nIYEKWi xqnN0NP93Si7fJhmeqesXffSNb8eEp8Mhqdvju5+/uaGEZtdDKPSpsyU1QZk+coU 9S9mDUb/UdmEt5mUPyK9ywduS7YZu6O61+u96hJVZDtPgRE4wHOwLCCXc+FZ5WDE 1iqavOPtGfxm8/6H0KM+HmphpJdyLQq1nsGYIpudq0TMZPEz8Pg1TXmsYDsENrt8 grrqaXIWHOaM1Fl7jK/VNGGzfMzsKlW0hSPoPJY68BkI4P3JP5YTXsytaZHU950m dsEkMzMQpMFwGhwd+OG/u03ogaEK8XyfOfgpLXr7ZiyNYUoQmIZlK1X8SHJKf8dZ CnSFM7FKkgsqIEC+5NboI2tzHiK18EozkqZmI47ukensicKPSQLLX81hD5UaSQZR SnjLELmUqGK51HL2YBZZEFPI3VmbCxymI7MElz5picTFtTpowRzWRv7gWs2s+sdy 4pc83rP5D7DvlWMMugYZyf4/jdBEjz7S8SrtgG/1cyuLrXjDnwxN96DfgTTC9ZDE lEccKlbIMKrGdUMP2LEw8rLQ9UyVRjeyRvon4GYwfk+ZAbfql0HjnIolz/drNPmH wXeTZ/axunJoSjuSh5bvEnyyGbzrCbDvBZ/3oZw8d7B0eZNstKg= =aq1X -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--