Date: Thu, 27 Sep 2018 20:03:58 -0700
From: Andres Freund <andres@anarazel.de>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Pluggable Storage - Andres's take
Message-ID: <20180928030358.uitg4kfesfbs3uce@alap3.anarazel.de>
References: <20180824025043.qscsnalejqwldmmf@alap3.anarazel.de>
 <CAJrrPGeU9m-2nRBJXLz_XLvMFjCv_Ggaseakc3VFYKMo5OZn=w@mail.gmail.com>
 <CAJrrPGeNUfvfbQoQTURgAm8SoMxtA64Mfg-CCi4iGtGstLuxXQ@mail.gmail.com>
 <20180904003308.r25cxramrfpvasxj@alap3.anarazel.de>
 <CAJrrPGendkg_keRLkNKdSUxguAGVT0FPcu3UoABJHdwTR3ie4g@mail.gmail.com>
 <CAJrrPGfH7awxE5jDwJ8_gU2J9LE56=jGjEEkXRTG37Js2EC7LA@mail.gmail.com>
 <CAJrrPGfQfiNE6Saw1edfCBZ5advfv=YxTwDRWJ4hUPZScvGmYA@mail.gmail.com>
 <20180921070534.tzplrjq4fol2zoti@alap3.anarazel.de>
 <CAJrrPGc2ca=iho_FOJpYxQNBqvJQK-3OUvmdo2VG7hDJhfOzzg@mail.gmail.com>
 <CAJrrPGfbh32BuiFYV0go06AQoWkkHmzB=HOG8wQa3R2WERT9_w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAJrrPGfbh32BuiFYV0go06AQoWkkHmzB=HOG8wQa3R2WERT9_w@mail.gmail.com>
Precedence: bulk

On 2018-09-28 12:21:08 +1000, Haribabu Kommi wrote:
> Here I attached further cleanup patches.
> 1. Re-arrange the GUC variable
> 2. Added a check function hook for default_table_access_method GUC

Cool.


> 3. Added a new hook validate_index. I tried to change the function
> validate_index_heapscan to slotify, but that have many problems as it
> is accessing some internals of the heapscandesc structure and accessing
> the buffer and etc.

Oops, I also did that locally, in a way. I also made a validate a
callback, as the validation logic is going to be specific to the AMs.
Sorry for not pushing that up earlier.  I'll try to do that soon,
there's a fair amount of change.

Greetings,

Andres Freund