Date: Wed, 3 Oct 2018 16:20:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Bruce Momjian <bruce@momjian.us>
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
Message-ID: <20181003072003.GG2609@paquier.xyz>
References: <20181003014409.GC2609@paquier.xyz>
 <20181003020706.hykmk4vmy6brovoj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FLPM4o+7JoHGki3m"
Content-Disposition: inline
In-Reply-To: <20181003020706.hykmk4vmy6brovoj@alvherre.pgsql>
Precedence: bulk


--FLPM4o+7JoHGki3m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 02, 2018 at 11:07:06PM -0300, Alvaro Herrera wrote:
> I see.  Peter is proposing to have a fourth mode, essentially
> --transfer-mode=clone-or-copy.

Yes, a mode which depends on what the file system supports.  Perhaps
"safe" or "fast" could be another name, in the shape of the fastest
method available which does not destroy the existing cluster's data.

> Thinking about a generic tool that wraps pg_upgrade (say, Debian's
> wrapper for it) this makes sense: just use the fastest non-destructive
> mode available.  Which ones are available depends on what the underlying
> filesystem is, so it's not up to the tool's writer to decide which to
> use ahead of time.

This could have merit.  Now, it seems to me that we have two separate
concepts here, which should be addressed separately:
1) cloning file mode, which is the new actual feature.
2) automatic mode, which is a subset of the copy mode and the new clone
mode.  What I am not sure when it comes to that stuff is if we should
consider in some way the link mode as being part of this automatic
selection concept..
--
Michael

--FLPM4o+7JoHGki3m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlu0baMACgkQnvQgOdby
QH1hvw//VV9UNJKBK08TlPQ+o9cBjhOjkAlXMQt/mrKocNh2ssXZxmqDaFw+xpJ5
UhSxUt1fVLM79LkUsspawmgTXeZiHqZAg/EoSrPI5KmAFKbP2sDMHFbi0tflS2yc
aRzFxaykCt09F+VZpVwxwoyLb5sPU+obqXE2swA2KelsDc5eruwWbbaqbxFYz/Cd
cEpgX8RYWHAQbv452c+15m2Qylq6r1f5/daKQSnAa9e1qyLMmnGK+ZCBhHXyUN4z
r9ao5fCRbStYrdaMXdPUBfZPNtHFYpBICUKJ3C8510WblM+L8hV4x6lfGCtB/GyN
41lmP0Y+5VOW4Jg/4aOAENj2psUyOFYu2obI+PxOoDOKsfEXrnI41QbEl9q2SZNd
ZxGKlS/igYds098k0ORPF8ywTmjm8CjT/rTIX2TmuhxseOahZfwvUbqjQYs7hZRw
Glc0aYV/aa3WzRU49dUZ9M4mMKuTQ/eudAXqheRw+mmCaKUYBau92tPTGCco9cOb
y74l7/BUBoCNus0Zxd1KwP4XEXktV+1SgDKQqZi9kTPdJXTgJ8eIIEwCpxIKbwCj
BPHQaeekwM38gYUc0u+DO1UZ1pO0IrIh1idFFphib8I6WnZfX8J1enRQg5Giaz1V
dKgDjZPSAzbFccKZJpGDAhnd3JjEzbJvG4UEMYpwUAq1caDyKJU=
=qwy0
-----END PGP SIGNATURE-----

--FLPM4o+7JoHGki3m--