Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g9RdL-0005hG-8y for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Oct 2018 09:15:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g9RdJ-0000d7-Lx for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Oct 2018 09:15:21 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g9RdJ-0000d0-7T for pgsql-hackers@lists.postgresql.org; Mon, 08 Oct 2018 09:15:21 +0000 Received: from [64.147.123.24] (helo=wout1-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g9RdF-0001J3-Mc for pgsql-hackers@postgresql.org; Mon, 08 Oct 2018 09:15:20 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 783789B0; Mon, 8 Oct 2018 05:14:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 08 Oct 2018 05:14:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=GWmqVIb9w/YdTU9sW4rQ2zwoAaZ U0xRxJ5Gk7awsAM4=; b=48OU8wGPrIK3q4KRqesrA12H9Ryx21ZuL9IEFuTk7mt uDulii17AqeaR2VLriw97qvlajQP3z3C3fIp0OHnGKPjIZSAoKGJWDiJ1kWo7NHp h1cPEmFYe7Ox2BnXLUs/u1rcye1klWrCB/MF0hSD+2eMnM6H5/BG5C/sy/cMjuKa jh/3hpPnHyTHlMyxn89FSsNt51bCLafazIFhncimxbPssQhXWJzHUIrtv666gMu0 bXmBc0VOXUSDdg1PEbmX2u64vXQcFQRcLFvYltolNw5IM67kbaKVHPx7Q8wCsbbX uyOTDz6MNT0GWy56lkuqdI0wSwMXr7v9BlHK2oxej4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=GWmqVI b9w/YdTU9sW4rQ2zwoAaZU0xRxJ5Gk7awsAM4=; b=HJJpkPmIW8HSUiwUw1NMPc F6DJxbOHiQ3SI3bfqh2S/o+gulGmc7vHrNi0puEr7IzuExwDrmhkbSTf8MmMSeKm 1NEcfebaEwuSr5+bK0EZKi/BSGUdFyoReS+ygw71n+XL9Y6G4uLcBkscYIGSKPjW yADSljN2RUxkXGzH0Eam4OS+CXYDzNIhvMccZmxuFazo9y+1iswgNlBWH/+E7m0Y WQI5tj+pt+iOvjKzg+Zej58S2qfi6LnglXPDC600g4qIY79QZybHOKdwmxZGKLIr xPUH/xynT/hnN5QY6MBtqcgEwNMOzFTeY7eBkGOoAkfuq4MCXstadW5p93P1HDkQ == X-ME-Sender: X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 37C68102E2; Mon, 8 Oct 2018 05:14:54 -0400 (EDT) Date: Mon, 8 Oct 2018 18:14:51 +0900 From: Michael Paquier To: Konstantin Knizhnik Cc: PostgreSQL Hackers Subject: Re: out-of-order XID insertion in KnownAssignedXids Message-ID: <20181008091451.GD2754@paquier.xyz> References: <0c96b653-4696-d4b4-6b5d-78143175d113@postgrespro.ru> <20181005080422.GA7863@paquier.xyz> <581a80f7-3992-f319-302d-7c9a384d64f7@postgrespro.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xJK8B5Wah2CMJs8h" Content-Disposition: inline In-Reply-To: <581a80f7-3992-f319-302d-7c9a384d64f7@postgrespro.ru> X-Host-Lookup-Failed: Reverse DNS lookup failed for 64.147.123.24 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --xJK8B5Wah2CMJs8h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 08, 2018 at 12:04:28PM +0300, Konstantin Knizhnik wrote: > The simplest way to fix the problem is to ignore duplicates before adding > them to KnownAssignedXids. > We in any case perform sort i this place... I may of course be missing something, but shouldn't we not have duplicates in the first place? -- Michael --xJK8B5Wah2CMJs8h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlu7IAsACgkQnvQgOdby QH2iqhAAiO6vE21I+lsK7EKtbZDUY1h4h801lQFngS2ZRao9qtcPGpLg3iSLU0Qa WJFdW3DPNGlOQLp/6Jvet9m9IvibkyU5TqkmHZzxQ/7tPkV5j3+FeZhRNQtBBJLp d9LIAQC5MBWdYxhTOn0dEn1sa9eLE8laR42L7hOuvr3sHFMyV1I3Qb5btxZp5GPr YEi1+5Rs2PZNHGL23QO3fAUTyITi1TsUuOSkEijB0LP17TPgnya+InjfhemEIal2 WvVBOx2ECwJqzO5kS9j8rR0aPhVBtFl9ggJbYy3Xo/yHue/+J0ha/pNhh81MhuRU brqNylB8ZJ28tpO00jgZiFN3onw/hmCOtxCNSvOCzaguEVyYMMtNGWzkJKQ0nIhA eNW7bmJehq6mmWsUI1EZ0b6HPaYjVUFYLYCLxlxOGSfRpjfFkLfZsvRIH2AYIM0T C84hqJoG1LRStPw0MCmaXMCFiwvZjlzSyFw0QGHA21WNy/C87TYJNqy9OPA34S7B 8Basrf9nIe52Uj6kGot+HBSHrpOmhIhZjL6xJmTs17KORb9xNATivPIBZ3VVkjGz 9jjHR/en43gwVxc0xgTpGAFCnDIoUEaFO2V67vbjnuzs1hx6xvnslVaTYCANu9jI 5eOXqEGoDZRl708USDD0S4DEseuy/g5N///kYp5MmCNNPmAC6uE= =9KOG -----END PGP SIGNATURE----- --xJK8B5Wah2CMJs8h--