Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gGTlk-0000ln-Ew for pgsql-hackers@arkaria.postgresql.org; Sat, 27 Oct 2018 18:57:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gGTli-0006eR-3c for pgsql-hackers@arkaria.postgresql.org; Sat, 27 Oct 2018 18:57:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gGTlg-0006eK-3Q for pgsql-hackers@lists.postgresql.org; Sat, 27 Oct 2018 18:57:05 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gGTlb-00061s-Ud for pgsql-hackers@postgresql.org; Sat, 27 Oct 2018 18:57:02 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id C19C21EAC; Sat, 27 Oct 2018 14:56:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 27 Oct 2018 14:56:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=2eWKvHH0Gdn0IKY5dVpfjB5Lx81 Df2cTbMZhpOTRS4U=; b=H7s4n1Y/SpzeMhaLCOuEfxtQQbUwaSQ8AccaSNiS4SH XXMhgpFYgsxBPHqIyVChYRQggQMAJqYo9+mAu7ba+29jrCWQ3oNslddXwujlhxkC kAiS4kSoDg0g9mvjekRSW8x0NdWWz6KwdY0Fr/HHKmP2n8y8FbKGUsspgsePdp8r BqFac7FoLYnwAPkIa9ny5541Zyoo2U+6aMajNfdS5iUiDdG6+WIiCU7WreqSO8wO 4uI6hUrdq45QIBOIQqHwdGHoHdlYpyoguNezheapwkGSdMxz1MdVgVTGMMy8CRiH A0Na3vFyHJ10MkULEcUgdC3wNFbsMeRMP/NcBVLSWNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2eWKvH H0Gdn0IKY5dVpfjB5Lx81Df2cTbMZhpOTRS4U=; b=GmfXAHI5Zly47fI22O7WuB cBmvBvLlmPaI2jLOcdJhHJLf8d4qRN0QC/7iYquorczYDOawIzz3EQRh4shh2WkI QJ7c2a6vp8CESVEk0l+VZnXiA32NpayMoLcEqksvqnuqAnZtxzIUxqvU6piyDUWB ofD5W1lYtWZnjpCqoKjyh/26JQuyQ/wka1OpkH65i2Yf6gGzWCc8UcxJHErDAaps v/9W7vzT3B7ty8+bYX1Jgcc0DHGOOqDP9y2AommaBD4dXFQktKRixP0uM+LxkNZf sd75WvGSGmG4rxhLr2bock8aKaQ1ZN1vCsF0ibNaMXbuR6iRvlmV1eW+bTwbyFPQ == X-ME-Sender: X-ME-Proxy: Received: from intern.anarazel.de (unknown [88.157.232.34]) by mail.messagingengine.com (Postfix) with ESMTPA id E34BE102E8; Sat, 27 Oct 2018 14:56:57 -0400 (EDT) Date: Sat, 27 Oct 2018 11:56:56 -0700 From: Andres Freund To: Amit Kapila Cc: pgsql-hackers Subject: Re: [RFC] Removing "magic" oids Message-ID: <20181027185656.2jiit4epdpk46dlh@alap3.anarazel.de> References: <20180930034810.ywp2c7awz7opzcfr@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, On 2018-10-28 00:21:23 +0530, Amit Kapila wrote: > On Sun, Sep 30, 2018 at 9:18 AM Andres Freund wrote: > > I think we should drop WITH OIDs support. pg_dump should convert WITH > > OIDs tables into tables that have an explicit oid column (with an > > appropriate default function), pg_upgrade should refuse to upgrade them. > > > > Is there any technical reason why you think pg_upgrade should refuse > to upgrade them? I think there is an argument to break backward > compatibility here and many people on the thread seem to be okay with > that, but refusing to upgrade sounds more restrictive. They'd not be on-disk compatible, because the column isn't stored as a normal column but in the t_hoff space. Greetings, Andres Freund