Date: Mon, 5 Nov 2018 11:30:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Surafel Temesgen <surafel3000@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump multi VALUES INSERT
Message-ID: <20181105023013.GD1718@paquier.xyz>
References: 
 <CALAY4q9kumSdnRBzvRJvSRf2+BH20YmSvzqOkvwpEmodD-xv6g@mail.gmail.com>
 <27171.1539719339@sss.pgh.pa.us>
 <20181017190528.GD4184@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xB0nW4MQa6jZONgY"
Content-Disposition: inline
In-Reply-To: <20181017190528.GD4184@tamriel.snowman.net>
Precedence: bulk


--xB0nW4MQa6jZONgY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 17, 2018 at 03:05:28PM -0400, Stephen Frost wrote:
> The point of it is that it makes loading into other RDBMS faster.  Yes,
> it has many of the same issues as our COPY does, but we support it
> because it's much faster.  The same is true here, just for other
> databases, so I'm +1 on the general idea.

Well, the patch author has mentioned that he cares about also being able
to detect errors when processing the dump, which multi inserts make that
easier to check for.  However, even if you specify --data-only you still
need to worry about the first SET commands ahead, which requires manual
handling of the dump...

I am honestly not convinced that it is worth complicating pg_dump for
that, as there is no guarantee either that the DDLs generated by pg_dump
will be compatible with what other systems expect.  This kind of
compatibility for fetch and reload can also be kind of tricky with
portability issues, so I'd rather let this stuff being handled correctly
by other tools like pgloader or others rather than expecting to get this
stuff half-baked within Postgres core tools.
--
Michael

--xB0nW4MQa6jZONgY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlvfqzUACgkQnvQgOdby
QH0zeQ//f4BH6UtDvK9nUNspt4/XHWOoalIV/5ICwSvqNjiSqwejKKZkBf5XnLDr
dUVv5hLzXGDtp+2w9P25dPU+uAQ0msMqaARlrrv4ieWDqmd9/3kVuNGeFSwzjKKG
ldf26QX6/jlVfcJy8pOFTTeD5fn6GRJ615zNiqOZbtMV9iiukzV3NWfrWHPzqYss
M+NehWTDL5zU8vGw8v/3ccVhdCUtDUjLN2TT5ebei1YNoS8YszExqrqR3OUuMW6q
gDRjAH2OwBK2W0ngoBuEEyjNWkUHqVK+puseL9LzzhANrxxE/X+kqWmdTfj0SrKd
cvG0WuiD4p4WjRyGPeScCWpgpSxgnHLbDrfteSHZTYk2GHUKmAXPcBgvu2b3F4fX
n2lESeqJBz3dtH5f4VDFc/vNIObbH4P4Ko7sVD8PFNWSQLcRC7d5k5FU7q8bW3O9
SFO1z4i30AuRKBCuqTi/VFJ49oOev+XS8oa3rXfwF0vfPq0pbr7vh8mchgHliEaC
OeMr0XnvISDNbZogkqrECPVBfkLBHzA9/7mt+hGF4zP7T0kCr6DzdQ+2oV4Iv0JE
iNW2yeiYZNW76ip//IXZ386Yxv/EZGW0qaVkhD8qrUr9pWtbo9X8bRmbmSyGzPfV
Ic43sI/IZi1Dq9TnYGQa3KYNwWHGCVa1nmdSbeL20OjP5Y3dY7U=
=MMlw
-----END PGP SIGNATURE-----

--xB0nW4MQa6jZONgY--