Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gKEZk-0007tQ-Mx for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Nov 2018 03:32:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gKEZj-0005G6-1Z for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Nov 2018 03:32:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gKEZi-0005Ce-QU for pgsql-hackers@lists.postgresql.org; Wed, 07 Nov 2018 03:32:14 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gKEZf-0001Nj-Pu for pgsql-hackers@postgresql.org; Wed, 07 Nov 2018 03:32:14 +0000 Received: by mail-qt1-x842.google.com with SMTP id n21so2613441qtl.6 for ; Tue, 06 Nov 2018 19:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=vPz4hEeHypfzU/u7JAjc38lLOYGbKd9E33DSyEcGEwQ=; b=YSPoMdrwy8HYDynDRxff1mvVm0HKWZqjBLJt/a6OvH9ZvUIKGKaFmzi0Do5owRuW5G O8gd+MuX7b4PQ5Ki6YyNnhS70as4orLZPBc5u5qf89gceUC+yYMqIT9YFsHxS8sdf5Fd b4pigjrlsDOhwEjf3C0N0nviFGDeCdnhGioDIdIkux+jp6yRMGAImbdi1VM9Mg1LxY6q UJsl63QMxYUHwbcOaBjvnTZDt28Vn82CTb/75MFd3233CdeaL7T6HMo4Tvs2/REJALbc GVg2lAqUrbWxxVzF02muY/3IfT5ZjoCG80AFrOwx9Re1aXkF0lpkv7DM416gRdxx/fgb mJMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=vPz4hEeHypfzU/u7JAjc38lLOYGbKd9E33DSyEcGEwQ=; b=biS60nlBZTUp1s4KPIcA4Una3QWKys42btpOka53wwqCptxfMtUPf6W3DA8pXbadB4 OhE5CgX4xu7kmssMU34O0HglpgbuMMnKyfSS9xPRx+h0QMP4yqQ4mBJCaGN4edmWOxwc g0gYfojCe0LrrRjRN6NSZmIYZFfvxuHDxO1KqVX39v+XemQqbLBeZS0e65yJz1Kv9pie t6u4Pct9dglz/1dR70dwtaFEnR06EC2TohdwoYIyGbiE59s7ncYL4oVstEDRJcIhu70s jGnSI3biUVI40uFBdL4MxsYxFF7Egg/IOPc1HKzO9T8/zTPRdcQLJeRDc3Q5mRTa/rKG 0M7w== X-Gm-Message-State: AGRZ1gKvF+iPIIyXxJRkltCcXhpk8sVaB8nCaiIc8s2s66aHHBNTiiC1 zhqKPYLV1c6dempSaVCuIGjMzg== X-Google-Smtp-Source: AJdET5d+0AE2ilEaxBhvAK15WiJW8pePQ+GW8g2ORGMJWj8XOBuyx8CAvfBjRnOb6VhNO3vVOxBHMQ== X-Received: by 2002:aed:31a3:: with SMTP id 32mr185116qth.234.1541561529880; Tue, 06 Nov 2018 19:32:09 -0800 (PST) Received: from alvin.alvh.no-ip.org ([201.186.80.75]) by smtp.gmail.com with ESMTPSA id b134sm10102041qkg.78.2018.11.06.19.32.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 19:32:09 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 3A4675B6; Wed, 7 Nov 2018 00:32:07 -0300 (-03) Date: Wed, 7 Nov 2018 00:32:07 -0300 From: Alvaro Herrera To: Amit Langote Cc: "Imai, Yoshikazu" , Pg Hackers , David Rowley Subject: Re: speeding up planning with partitions Message-ID: <20181107033207.cdisp33ryrgeidef@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk ISTM patch 0004 is impossible to review just because of size -- I suppose the bulk of it is just code that moves from one file to another, but that there are also code changes in it. Maybe it would be better to split it so that one patch moves the code to the new files without changing it, then another patch does the actual functional changes? If git shows the first half as a rename, it's easier to be confident about it. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services