Date: Fri, 9 Nov 2018 18:11:06 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: =?utf-8?Q?J=C3=BCrgen?= Strobel <juergen+postgresql@strobel.info>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
	Amit Langote <amitlangote09@gmail.com>,
	Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15212: Default values in partition tables don't work as
 expected and allow NOT NULL violation
Message-ID: <20181109211106.ue3nkyyv62lyspab@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <00ca74fd-4f88-877a-823b-2891f3f212ce@strobel.info>
User-Agent: NeoMutt/20180716
Precedence: bulk

On 2018-Nov-09, Jürgen Strobel wrote:

> I am slightly confused now, I thought this landmine was already fixed in
> master and what remains is only whether to backport it or not? Which I
> guess depends on whether this is classified as a bug or not.

Hmm, I changed (and back-patched) what happens to the NOT NULL clauses,
but as I understand the behavior of the DEFAULT clauses has not changed.

> Since the fix has the potential to break current applications and the
> documentation is vague about wanted behavior I think it would be
> sensible to add a warning only, even if we agree to call it a bug.

Hmm, the part I was first proposing to backpatch as an ERROR was a
mismatch in the COLLATE clause; then I talked about using a WARNING.  I
ended up backpatching neither -- only immortalized the current behavior
in a test case.  I think it should be an ERROR, but in master only.


The DEFAULT clauses are a different problem (landmine) :-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services