Date: Tue, 20 Nov 2018 10:42:41 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: s.cherkashin@postgrespro.ru
Cc: Michael Paquier <michael@paquier.xyz>,
	Nikita Glukhov <n.gluhov@postgrespro.ru>,
	pgsql-hackers@postgresql.org
Subject: Re: Psql patch to show access methods info
Message-ID: <20181120134241.36tjfswliqimvncv@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <64178681578cd2f1013db32bb7c00ddd@postgrespro.ru>
User-Agent: NeoMutt/20180716
Precedence: bulk

On 2018-Nov-20, s.cherkashin@postgrespro.ru wrote:

> Ok, I fixed this.

Cool.  I'm not sure this is a good idea: "c.relname::pg_catalog.regclass"
I would use c.oid::pg_catalog.regclass instead.

But before getting into those details, I think we should discuss the
user interface that this patch is offering:

\dip [am pattern]
  lists index properties (according to doc patch)
  * OK, but why do we need an AM pattern?  ... reads regress output  ...
    oh, actually it's an index name pattern, not an AM pattern. Please fix docs.

\dicp [idx pattern] [column pattern]
  list index column properties
  * I think the column pattern part is pointless.

\dA{f,p,fo,fp,oc}
  Please explain what these are.

I think this is two patches -- one being the \dip/\dicp part, the other
the \dA additions.  Let's deal with them separately?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services