Date: Mon, 26 Nov 2018 09:13:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Sergei Kornilov <sk@zsrv.org>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: allow online change primary_conninfo
Message-ID: <20181126001329.GC1776@paquier.xyz>
References: <19513901543181143@sas1-19a94364928d.qloud-c.yandex.net>
 <20181125214313.lydvmrraqjfrb3s2@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Fig2xvG2VGoz8o/s"
Content-Disposition: inline
In-Reply-To: <20181125214313.lydvmrraqjfrb3s2@alap3.anarazel.de>
Precedence: bulk


--Fig2xvG2VGoz8o/s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 25, 2018 at 01:43:13PM -0800, Andres Freund wrote:
> On 2018-11-26 00:25:43 +0300, Sergei Kornilov wrote:
>> I think we have no futher reason to have a copy of conninfo and slot
>> name in WalRcvData, so i propose remove these fields from
>> pg_stat_get_wal_receiver() (and pg_stat_wal_receiver view). This data
>> can be accesible now via regular GUC commands.
>=20
> Is that wise? It seems possible that wal receivers run for a while with
> the old connection information, and without this information that seems
> hard to debug.

No, that's unwise.  One of the reasons why conninfo is around is that we
know to which server a receiver is connected when specifying multiple
host and/or port targets in the configuration.  Please see 9a895462 for
the details.

Removing the slot does not look like an improvement to me either,
following Andres' argument.
--
Michael

--Fig2xvG2VGoz8o/s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlv7OqkACgkQnvQgOdby
QH3KrQ/8DZ0HXt6sMLWLLyfQyFaUNB0st8JU4OHJN9i6WNqXdUvg1TkHcAptSGPQ
hX1gpkUEp7DHE76ZdX5/1p9v54zcMlLLsxyyNUSRVKwFRdv2YcXTTpiL8GlJhYPK
BedAxcTX+0VpBKMMwsPLiihK6Er5d7j6Y18ATQAp2+V95B0Yz2OojqyKWA/MEvcp
nTPueSPq28ETaD5+u511++oB+eKqyo+VxvaN0sXBqbIBDaQuhFprSygbDbvAN5kd
nmQLkzMn7b2KVRJNxlKHAalfTryBhP07xSMG4+xuWskN2aM5K1/I7P/3XmEP2iuw
Ymo6L2IJJOhDxE0rM3ad9dTyJ1Ynbbm7ww51ikriiD4rVcqdxDAx+ge/gSTi846d
moQxW1FvtPi/myLnq9zqtm8JH0+MCCL79Dw3q8nr0Do+cZ6fDLw8mt6bn6br4pi9
ECZQMFvBmQ775l+iVSF/OlHqfK9785wLDd3XOxdxDHMBBlZY8uXHl9rMz6Cst8Wt
CrBYyt6S4zsStJ7RbZ9yKVzKmQUTEe1/0SuvHePjLtEY4gXHXfCT3v9D60Yt1BJI
LJRKbzfEpohgvNYnujyGYzlVgGdfTWES1STzo/mljmof5XfWm0D54e4aRItKETpd
yx9ADjWMp12bHKQF/xDJ39/xsUn/6srRP6+OqcDxfhpNsZSwCQo=
=834I
-----END PGP SIGNATURE-----

--Fig2xvG2VGoz8o/s--