Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gS3oE-00061o-9G for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Nov 2018 17:39:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gS3oC-0002Jm-PX for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Nov 2018 17:39:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gS3oC-0002Jf-I1 for pgsql-hackers@lists.postgresql.org; Wed, 28 Nov 2018 17:39:32 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gS3o9-0003kf-OQ for pgsql-hackers@postgresql.org; Wed, 28 Nov 2018 17:39:31 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 8D5AC5F7AC; Wed, 28 Nov 2018 12:39:28 -0500 (EST) Date: Wed, 28 Nov 2018 12:39:28 -0500 From: Stephen Frost To: Bruce Momjian Cc: Peter Eisentraut , Kyotaro HORIGUCHI , pgsql-hackers@postgresql.org Subject: Re: pg_stat_ssl additions Message-ID: <20181128173928.GR3415@tamriel.snowman.net> References: <398754d8-6bb5-c5cf-e7b8-22e5f0983caf@2ndquadrant.com> <20181120.173122.55744021.horiguchi.kyotaro@lab.ntt.co.jp> <01e7dd28-6bcc-5c26-a77d-54340a51633f@2ndquadrant.com> <20181128173454.GF24817@momjian.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HjWPpdYqeqs1tRt7" Content-Disposition: inline In-Reply-To: <20181128173454.GF24817@momjian.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --HjWPpdYqeqs1tRt7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Bruce Momjian (bruce@momjian.us) wrote: > On Wed, Nov 28, 2018 at 06:31:59PM +0100, Peter Eisentraut wrote: > > On 20/11/2018 22:41, Peter Eisentraut wrote: > > >>> - Adds new fields to pg_stat_ssl: issuerdn and clientserial. These > > >>> allow uniquely identifying the client certificate. AFAICT, these a= re > > >>> the most interesting pieces of information provided by sslinfo but = not > > >>> in pg_stat_ssl. (I don't like the underscore-free naming of these > > >>> fields, but it matches the existing "clientdn".) > > >> clientdn, clientserial, issuerdn are the fields about client > > >> certificates. Only the last one omits prefixing "client". But > > >> "clientissuerdn" seems somewhat rotten... Counldn't we rename > > >> clientdn to client_dn? > > > I'd prefer renaming as well, but some people might not like that. > >=20 > > Any thoughts from others about whether to rename clientdn to client_dn > > to allow better naming of the new fields? >=20 > Makes sense. The SSL acronyms can get very complex. Agreed. Thanks! Stephen --HjWPpdYqeqs1tRt7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJb/tLQAAoJEO1sijiDR2RVkOgP/iUcMcdg8gIWlEMd7hagYYF6 jmiKMTgwWvo20ocjscVITE/DfcTnk6oh9L3hvj6UdamEwPldqAmh7JKkrYrx/7VR P8fAec3MEqp+wnugfPIw2mNa3BtyoAsijP5Ft/nbmaLJrnfALelboJJ9+/VfT+Me pripunVLJDccBTvsO/musWS+myYUvxAl8lJtIxJfejuWlhbU2SYigelTHUb6ebI8 OjZawJD+bOyNxnsuqeUUFLY5xJ68Rt1jBx+ePkCwJz/QLGEy3XCxhgIg0JPXPXVh SqMxAR7zXO/pPV4gnz8oV3/zTR4cPXj6atjgytkl3uRafjKGr0f4iJCkF8z5J6kC 6dLR7GufY47uj20YnMxzKVorUfL/nITp6wBAenz5yTO5kqxJMTU6petA3TQDGb9G P5HQ7Gcc0TChjqTP7I7WH1s/1gHwsX3XvWTOhWJ3TGu65sQG72bAg5IjkZackDaw +Z9bOBhxoZxJM+R+Zt1/YCbBr+vSBVugaalZooHZr3LnR09iaywpNMUZcvPvO0I6 y2thVDfpv8YLyYBSYsfFoutUxqNbkSzXEdBRflrSuRfZ9lqL/5x0BrurGCyuyywr ZVZS4Tpady/6qm3IA6kfH0rnJJAsUV0WaEnHiEd8QGBrE0LrWJG7IHNNcNNR+RIc wk24MQb+cwMzzdWiHaX6 =R5Oz -----END PGP SIGNATURE----- --HjWPpdYqeqs1tRt7--