Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gSUBA-0003zG-Hr for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Nov 2018 21:49:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gSUB8-0006pE-VM for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Nov 2018 21:48:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gSUB8-0006od-NM for pgsql-hackers@lists.postgresql.org; Thu, 29 Nov 2018 21:48:58 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gSUB5-00008a-Ml for pgsql-hackers@postgresql.org; Thu, 29 Nov 2018 21:48:57 +0000 Received: by mail-qk1-x744.google.com with SMTP id y16so2019439qki.7 for ; Thu, 29 Nov 2018 13:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=gKtUKSbhqWG9K/+k2JJdUOxwA8/kflj05i7P+GQjMAA=; b=xid0D0fJiUlY+yF01CLX02xmGED5mTUed+iaNweh5mdvYru+YoTQWGLJWBGbh5dJdP tDIuLQUFxBj1YIoQ7ZzCh02QTenKdSdipWcMO/HliH3/BeeZCiIIkRymzk37DSxHtQYD CoTB4789UgaKpYENWjMhuV4sd64NMJuDsvdFxDf2dqnl6lmXItIwJtFi7TX4MBvnoOoJ 9vjC27si0S6HigUpItwhwiGLfTIbbXvL0ik7EuDCvcJ0ZA0N58tw7R+XNN5FWqZj1bOu zU0UI558SL7BdqYbHrwcizojqDlmLdSbaswbpO7F5+kwFLFt5D5h5CBU7IrFGfCGni8/ diCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=gKtUKSbhqWG9K/+k2JJdUOxwA8/kflj05i7P+GQjMAA=; b=QPe+caHJacd8lPKStXPZahfDgPf/6Rs+LStbii3yXm3SeClGRQud3tN6TdUfdHhsnA Hm46Js0njX3cdVEzj/VAmg8MxOO7AKJU7ziEHsGn8kNFaKys3Dh3FeIpavWr7VZ+u6LD ZSydjVY/u9Y5MK7/N9Dc8FAGAPNa/YKU5GVykTMVRIT8Z2lfVHhJZmGiM+hpKo4/LEu/ 2FnqIvyacwV92GlwbQgq6vkpGggiTdulBONPJy8kp30HQUA+RR6Il/e3hxdUrlFxiD0o rPmksn8fqzek8Ncpj+mnjJs34axLWT5jlJFyP1z/hKWWuzeo+nPlgy/sUD+eZQcZUP6z B4dg== X-Gm-Message-State: AA+aEWZwTwLFQgK1SnAKsZWSjgBJkohrKmFmQxXmgYCeNBd3+T+IVnUh A66oMsIxEGL3aQuf9eMApnXeXg== X-Google-Smtp-Source: AFSGD/XLYkb9mwfjHl5VUtKMtiibtRBIH+bLq+s8tJ31Mo3/cSmqmZZkZr9hCEKQ2jVTQBArAUkBOA== X-Received: by 2002:a37:a141:: with SMTP id k62mr2977851qke.280.1543528133678; Thu, 29 Nov 2018 13:48:53 -0800 (PST) Received: from alvin.alvh.no-ip.org ([201.186.80.75]) by smtp.gmail.com with ESMTPSA id a90sm1816816qka.30.2018.11.29.13.48.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 13:48:52 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 834A45B6; Thu, 29 Nov 2018 18:48:50 -0300 (-03) Date: Thu, 29 Nov 2018 18:48:50 -0300 From: Alvaro Herrera To: Adrien Nayrat Cc: Thomas Munro , Dmitry Dolgov <9erthalion6@gmail.com>, Tomas Vondra , vik.fearing@2ndquadrant.com, Robert Haas , Michael Paquier , David Rowley , Pg Hackers Subject: Re: New GUC to sample log queries Message-ID: <20181129214850.kiq6mvofsgplqjdr@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thanks! I pushed this with two changes -- one was to reword the docs a bit more, and the other was to compute in_sample only if it's going to be used (when exceeded is true). I hope this won't upset any compilers ... I wonder if there's any sensible way to verify the behavior in an automated fashion. Who know what marvels we'd discover about the reliability/uniformity of random() across platforms. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services