Date: Tue, 4 Dec 2018 10:23:20 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: additional foreign key test coverage
Message-ID: <20181204132320.kzismcb7bajz4lvc@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7ae17c95-0c99-d420-032a-c271f510112b@2ndquadrant.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On 2018-Dec-04, Peter Eisentraut wrote:

> During the development of my recent patch "unused/redundant foreign key
> code" [0], I had developed a few additional test cases to increase the
> coverage in ri_triggers.c.  They are in the attached patches with
> explanations.  With these, coverage should be pretty complete, except
> hard-to-trigger error cases.  Interested reviewers can also follow along
> on coverage.postgresql.org.

Hmm.  One of the things I did for FKs on partitioned tables was remove
all the cases involving only unpartitioned tables, then run just the
foreign_key test and see what the coverage looked like -- in the first
versions, there were large swaths of uncovered code.  That guided me to
add a few more tests to increase coverage in later versions.  This is
all to say that I think it would be useful to include the case of
partitioned tables in the tests you add, where relevant.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services