Date: Sun, 9 Dec 2018 11:14:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Too-short timeouts in test code
Message-ID: <20181209021412.GC1833@paquier.xyz>
References: <20181209001601.GC2973271@rfd.leadboat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xB0nW4MQa6jZONgY"
Content-Disposition: inline
In-Reply-To: <20181209001601.GC2973271@rfd.leadboat.com>
Precedence: bulk


--xB0nW4MQa6jZONgY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 08, 2018 at 04:16:01PM -0800, Noah Misch wrote:
> The 180s timeout in poll_query_until has been trouble-free since 2a0f89c
> introduced it two years ago.  I plan to raise the timeouts in question to
> 180s, as attached.

That's annoying, thanks for tracking those down.

> @@ -72,7 +72,7 @@ my $endpos =3D $node_master->safe_psql('postgres',
>  print "waiting to replay $endpos\n";
> =20
>  my $stdout_recv =3D $node_master->pg_recvlogical_upto(
> -	'postgres', 'test_slot', $endpos, 10,
> +	'postgres', 'test_slot', $endpos, 180,
>  	'include-xids'     =3D> '0',
>  	'skip-empty-xacts' =3D> '1');

Instead of allowing callers of pg_recvlogical_upto() to define the
timeout they want, perhaps it would be better to hardcode the timeout
limit within the routine?
--
Michael

--xB0nW4MQa6jZONgY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwMenQACgkQnvQgOdby
QH0ECQ//fp7juhA2SHi+Y0eYt0D8u2fqzYt1Qsdx+vlUo6FzW9fbu2xDPtlXTwRT
w9hZbr7Il5rbuXawpb4weg5pgHuH76Kcw36Ssy3EP+buhbHwFa1HKkIVpsF7yLTy
9+JIEwNissh/cZhtOanvXjC+lDD34CW4TOKDTASDYbRtWyXXl3ZCgrMtIeRmIljY
rFuJXAXV1TPDkeXy9PMzq0WNV9b5GRkcVwefXL7mAKTVhp55QD08E9ZIPTBrt5nR
pDO7VUJdcB9IiIlo+AA2IV8l87Lpk4ajNjQOQm/JViolc7TybKQRGaWwd7C8yJVX
p4lO8h1WA/+anHqqIxSZpNhLxzMFVmorhJjgHXa0P0yh4RnW5kMUbqwij4Zn7W2B
4X0kim6gMSatpWZbXgWKcyG6rKtCOXQq7PgMkdSg3g6ZTvDmhwx0E4CncyVq9yfW
aEhX8NStXUXR/Ktd8UyN4YbwhaPqjs1R8wDOetQUKkpQjDx3KZH+i5kzQidZeYNF
r7NGA5jSaDX3HP6YjKVIWmU9jh1APrZZAtkS4q5KUIplnB22YWmsvHlJWXB86+PV
toWtk2EJBhwoFThqPC+3XVhlNjOu4ADe9IVKnBYTsTYTrb9iHurMGUcHvCn7/H3e
T65Q6gLkn1fJvvHoAqMsFuJ1wnTLDZ3Wp3w6l1YXxfpUuc8c3IA=
=Q76V
-----END PGP SIGNATURE-----

--xB0nW4MQa6jZONgY--