Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gVtm7-0006ic-R8 for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 07:45:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gVtm6-0007SZ-HM for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 07:45:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gVtm4-0007SS-Mc for pgsql-hackers@lists.postgresql.org; Sun, 09 Dec 2018 07:45:14 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gVtlx-0005AE-6X for pgsql-hackers@postgresql.org; Sun, 09 Dec 2018 07:45:11 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8AF0E21161; Sun, 9 Dec 2018 02:45:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 09 Dec 2018 02:45:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=9iaiEo/ALRd9XOKbk7Uq+9ADR+A OfK6dzjVKeP81IIo=; b=liB0MNwHaEFgswxxukOpBxCZ99yAh8U7pHmcJvBchzr U6tzIPFVfgtvGR35DAOXHp0x9OmIUFOb6+0IK7UP3NFx7mCFAYh84mAsnh1je3Lz BNo9SF1SOsVJ+R9skd4PMZ7PPLh6smV/jr6tbyL7OoDTnYHL1Kcs4EqVzXspLVgn H0QzW3W/+WWe01xAQU2iurFMV9ju2KYeFhk7NTHMJG/LXO0x3kEyh5juSKbb5w+N UDP7cE6DeGNj6K72n16PR2hBSFu1WeWAXwAjAFnfIkO9aCfkoowuMhnVCUrnM/Hw nkTRAwpwA0AOfPLh3Ot2crcxDam8zJ4Q8eKYRQsMtng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9iaiEo /ALRd9XOKbk7Uq+9ADR+AOfK6dzjVKeP81IIo=; b=N0nLdwJtixyNnD1GHpk3EL hxH6KQAoUMpJB2ig/olRXZ6elh1FsarOLH6J92BR7ZiWwPxlLpLFy9IAlVhuzBdp bwN0KEAIt0nicC+Lgnbp8TgKiC9snzDltWxyvIMcfjrVCS7t9PqXaDHiUPF5oy8q YEiMgcBmulBNTOazBs9K9bWqk2libPorcwlPhhhlB9WdHFmGl89sy6r5dkQP6uf/ qSqGoG25gqN9eh3QRmsuINUZLfj7e7vOS9Jb+6chu5rs03Hq/kXR8gAJ0saRxxfD EPY2+WmPCF+k6eXY2It2wAzH8lsiF3A5hzC4XUJtMl6ZkzWtnEnYGmA4geXB6hng == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudegvddgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdejtd dmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgt hhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqne cukfhppeeiuddrvdduhedrudefjedrudeivdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 70C55E405B; Sun, 9 Dec 2018 02:45:00 -0500 (EST) Date: Sun, 9 Dec 2018 16:44:57 +0900 From: Michael Paquier To: "myungkyu.lim" Cc: 'Masahiko Sawada' , 'PostgreSQL-development' , woosung.sohn@samsung.com, don.hong@samsung.com Subject: Re: [Todo item] Add entry creation timestamp column to pg_stat_replication Message-ID: <20181209074457.GF1833@paquier.xyz> References: <010201d4854b$ae87e510$0b97af30$@samsung.com> <20181129070020.GD2356@paquier.xyz> <00d401d487bf$98727c10$c9577430$@samsung.com> <20181130085415.GI2267@paquier.xyz> <20181204035625.GQ3423@paquier.xyz> <20181204060657.GA6859@paquier.xyz> <03f901d48ba2$6398d430$2aca7c90$@samsung.com> <20181207064034.GR2407@paquier.xyz> <063901d48df8$83d22460$8b766d20$@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jt0yj30bxbg11sci" Content-Disposition: inline In-Reply-To: <063901d48df8$83d22460$8b766d20$@samsung.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --jt0yj30bxbg11sci Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 07, 2018 at 03:45:59PM +0900, myungkyu.lim wrote: > Thank you for your attention! And committed. There was one thing that the patch was doing wrong: there is no point to convert the timestamp to a string if no log message is generated, so I have added a check on log_min_messages to avoid the extra processing for normal workloads, and pushed. Thanks for the patch, TODO_item--. -- Michael --jt0yj30bxbg11sci Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwMx/kACgkQnvQgOdby QH19Ng/+PC6qc/5+EgQ2wko6qp4UfQMRWW1xj40B45rnQNLSXnyOABgE8e7fn8q2 OsG3WZdDELQXmmHKWRKxaqSXZeNiMb6wlABXntbeNlmYFJouRMjvsI7hRirg5Y3S A3toa4kATtgHcGeVMBVLPkv8hkd6waXye8pbcEFqAy2ixHUar7kANxRanDYBuTkd Gr5/LPJVTg/uypQpwalCN8FbtmnngurwnCYAT18F8QOJlqodGq0Ouv/H5O9X+Lar eBS2zdKFC63P0GrPP7wW9oTQf7i29SjIxl3k7b4lAuSkJ4QuTh0c5utaPPTaw1lm YxcyDI4Hf6zRQfdwkWoPRV2YOJMdgbJKwW5w45du5PkL5Y3sFIeyx1Fy7ciBuas3 Vfdq9nW8jAUAKn43owP2OkXN38A9RGm81AmPw/auqNeayg1asuW/v65sGxwgWuu/ /V/5s3vcxdcTjr70l9OkZV66IMg4ZAflL14C82ocAL9S6J7ZZmHmHEi5hqqOW4ae 4oOirwwl8/I9ZTUbNlMcraj03cS8v1t7WAiyr/EwE0TdeJwi5d6T3v8aVWeZNe8Z 6pTSi4BYoewX3dSBfhpAU5or8DHmGGPfLcNdurNl+o29T6RRxsM9FyDColJU8/m+ C6Ua2K5mNzb8Dwf1IxGWiSbt2+5XPp4+Q4/i//I4lOK5/lKIPzA= =GcsT -----END PGP SIGNATURE----- --jt0yj30bxbg11sci--