Date: Sun, 9 Dec 2018 12:48:15 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Postgres hackers <pgsql-hackers@postgresql.org>,
	Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Subject: Re: pg_partition_tree crashes for a non-defined relation
Message-ID: <20181209174815.GD3415@tamriel.snowman.net>
References: <20181207010406.GO2407@paquier.xyz>
 <20181207230540.GA12740@paquier.xyz>
 <6105.1544243612@sss.pgh.pa.us>
 <20181208065436.GC1989@paquier.xyz>
 <20181208134608.GY3415@tamriel.snowman.net>
 <20181208231507.GA1833@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="aNC6T5u32QnGnwux"
Content-Disposition: inline
In-Reply-To: <20181208231507.GA1833@paquier.xyz>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--aNC6T5u32QnGnwux
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Michael Paquier (michael@paquier.xyz) wrote:
> On Sat, Dec 08, 2018 at 08:46:08AM -0500, Stephen Frost wrote:
> > I wonder if we maybe should have a regression test for every such
> > function which just queries the catalog in a way to force the function
> > to be called for every relation defined in the regression tests, to
> > ensure that it doesn't segfault or throw an error..
>=20
> Like sqlsmith?  It looks hard to me to make something like that part of
> the main regression test suite, as that's going to be costly and hard to
> scale with.

No, I mean something like:

with x as (select pg_partition_tree(relname) from pg_class)
select 1 from x limit 1;

or whatever it takes to make sure that the function is run against every
entry in pg_class (or whatever is appropriate) while not returning the
results (since we don't actually care about the output, we just want to
make sure it doesn't ERROR or crash).

sqlsmith, as I recall, doesn't care about ERROR cases, it's just looking
for crashes, so it's not quite the same thing.

Thanks!

Stephen

--aNC6T5u32QnGnwux
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJcDVVfAAoJEO1sijiDR2RV6UsQAISc4afcxzTjUt1i1L97QZ1j
zGLRB8Nu4ah7R6Xm5sGB7vtFbRFoKf0n/Vq6WsRclOFnIlRWb8l5n3V6ryD9UwfW
rnY8a5BU3/YpVZCeaWeqpPNpW+d1lKZCnMtXy8M5rmfqzOCLyfZkr+7Tm/WFFhKG
N6qzdrniPVIxr3jdGVlrO4k+u5u3b9PQE1cUnVMd6I2Y6Xzjrv5QUQ+XItl8+omm
rr25/yjo0TVQNrNwrJzr0MJg9kkP68F+GtxrZS0+JHUsONzqyEeExtzaJXMAzKMP
cqbBZQMxYhJbqvGu3H8stTUqFkcRSDCV5rQ4bHTt85dvjuMCtbEQCl63frmgcYBM
rwhSf51+gMpkNE3aEJOBx7AYaLHl4CKiUtyhLAhkB8MZCsCEiFUi6LsHGsww0vAL
uvbie6fIfNv9w68LVtHvQFAROM32Fbm1EJWF7EBBlmwxAZxFUeb15x4WiB+6gWjf
BVT3XWH8IxyY947e2hkAj0M/Bi6zvz82RWPnIpxfVJsOUuHMLupWOA9sByACZ943
HZgzTwjM5cWcdbc/Vt9sLkyM9sWNyitruzAiXyyoPH162jPqDZ9AGbfwJD384wfw
hjpU86J5YR99ja+yR0XEquRtOfitJnIA07fX+woKqNZGh0U53jzARm5HWR5wOXp9
T5pvbdz+J11ztrtIF1qu
=Njk5
-----END PGP SIGNATURE-----

--aNC6T5u32QnGnwux--