Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gW5xO-0004U9-8k for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 20:45:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gW5xN-0002OP-2n for pgsql-hackers@arkaria.postgresql.org; Sun, 09 Dec 2018 20:45:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gW5ur-0004Wm-KN for pgsql-hackers@lists.postgresql.org; Sun, 09 Dec 2018 20:43:05 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gW5uk-0005Ar-9N for pgsql-hackers@postgresql.org; Sun, 09 Dec 2018 20:43:03 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 912EE5F7A3; Sun, 9 Dec 2018 15:42:57 -0500 (EST) Date: Sun, 9 Dec 2018 15:42:57 -0500 From: Stephen Frost To: Tom Lane Cc: John Naylor , pgsql-hackers Subject: Re: automatically assigning catalog toast oids Message-ID: <20181209204257.GH3415@tamriel.snowman.net> References: <18075.1544380583@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qKAT8C74xUVCDx3f" Content-Disposition: inline In-Reply-To: <18075.1544380583@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --qKAT8C74xUVCDx3f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > John Naylor writes: > > Commit 96cdeae07 added toast tables to most catalogs. One disadvantage > > is that the toast declarations require hard-coded oids, even though > > only shared catalogs actually need stable oids. Now that we can assign > > oids on the fly, it makes sense to do so for toast tables as well, as > > in the attached. >=20 > I'm a bit dubious that this is a good idea. It's handy, at least for > forensic situations, that the system catalogs have stable OIDs. I tend to agree... What's the advantage of assigning them on the fly? Thanks! Stephen --qKAT8C74xUVCDx3f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJcDX5RAAoJEO1sijiDR2RVhm8QAJv7+ELp1UeEoTwxIPkiJxst MgccwWOdNfMXRrPl5cxzoBXgJ5+YaZW0+Of3pYaTxxBWOu2J7IfBdnF2XPs0cVjY NcA0+0r3XKGhr2viHanbtV9L0jqtVPM0oExGJL8F8kaJIjQ5+BvxSsVHDPQPlFTg 31RM0A7G9GZiy+vPqeYwO86a1F54IEYFK6kV2+sbfS9k6cSCPKUolfjWCvoWRiy1 uHMx+8YP6S41xt1HDn40x5+5RV67LpAc+cPYccEyRe3kpjamS2xrp2gWLZ8PYbxA ZQKd3IGkPcGpOkijA0iY19YvqVH8p1J1M+D4hgY/Q7CAK6F5w/iw6Xjlx1bF+yjZ p0yXean5y3d+grFwVKqMq2W/Q3dlyVHijMSnFzB2H7ZKIsOVlQ+qE8K3OY+usRSM S3Vk8it5zJIUVQsFAScer+5QZorfYMlvcTzyNhpIvp4IY8M23EbUGWuaJNt3HIHz H+MRrUkaC1eIlD3r1R+bZz5+Q2VckZUBCy9zRfkk++z7ua565tdsC8N4QD3bUZlL djOOn+IOfpOQVFuNgu/48Q+ElncyvUzxDlh920TuswtTidDewbchrx6OeIissJvy E0PdNatqOzlpUWCNWYVznGxEa3WcYe0I0KGEeux8Qn8uOcTowTg9cU2/jy5jq9je GsUAnkHF+GnVrcFxowmL =aCvA -----END PGP SIGNATURE----- --qKAT8C74xUVCDx3f--