Date: Mon, 10 Dec 2018 15:33:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Christoph Berg <christoph.berg@credativ.de>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log PostgreSQL version number on startup
Message-ID: <20181210063307.GD1105@paquier.xyz>
References: <20181121144611.GJ15795@msg.credativ.de>
 <20181121163246.GR3415@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="m1UC1K4AOz1Ywdkx"
Content-Disposition: inline
In-Reply-To: <20181121163246.GR3415@tamriel.snowman.net>
Precedence: bulk


--m1UC1K4AOz1Ywdkx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 21, 2018 at 11:32:46AM -0500, Stephen Frost wrote:
> * Christoph Berg (christoph.berg@credativ.de) wrote:
>> it has bugged me for a long time that there's no clear "PostgreSQL is
>> starting" message in the server log file. I'd like to change that for
>> two reasons:
>=20
> +1

+1.  One complain which could be formulated is that this makes the
logs at startup more noisy.  Now your patch has an issue if you want to
ensure that this information gets added to the log files, because at
this stage of startup the GUCs are not loaded, hence this is sent to
stderr, and perhaps not on the log files.
--
Michael

--m1UC1K4AOz1Ywdkx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwOCKMACgkQnvQgOdby
QH2w6w//ZKAGrZhrc69FFl0KOzmw9gFaPnd7Cprp0soSUFVEdU7b19mMQk2bxhVr
880MkAPFpYQpRApoqs+wiV/xfTYUM4+SeV/u91AX0/AXwEN754KcJFKXOlp/w9+w
H9F54pBrMJkHYyT/xl+k3lh3/eQK30bGwBGVV1XgjXdMEg0JVkpxYCZeB5uXpoQ4
b6/JnjlYI8vXSNuQ0kFhx6fPZDJfwEvvHlibbprsTmRaRz+FMoWWYxfVtnxeA2UJ
/jHKR9Sd4BaPLx2MDj3CvZYgoxCWMtM8z+TPQKi59D8zJGru/CKvq/F5PCsIpzoo
fKPanJCW3zqGAYusV1hcbFXj0csWaYZGaxHuoKveOPBPnRXr65uw69bYjNnv3ld+
5ag2EpIsB4ht8fxo9L7Q1njBcrtApOC7LTRxphDZbqHKUphyrLEe8aUyesr6IqOq
pETElBOL4Fi0JTdxHUFp29fBaVx25RHy0khEiGSgKzXIcJjUyDhWc1DBFmFT9rzd
6p2q9Dcoow7YydAuKkSVHxRlyg8UKP6EMQBi1GkBPRWqZ8l1q+SNQNxr7TXez2mR
bpWYcSTWHz+Ws7rr7JQcyTVZ3B20iD+1Dz17anudZtC+UgbVNHFww/M4qglkhAQA
AK25+ujXIQTP+ZXvP7DTu3yxQfBmYAO7PFQAb5yqv9Z6WluW5ek=
=rb2R
-----END PGP SIGNATURE-----

--m1UC1K4AOz1Ywdkx--