Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gWLVM-0003fP-0E for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Dec 2018 13:21:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gWLVK-0007uv-PF for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Dec 2018 13:21:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gWLVK-0007pv-Ea for pgsql-hackers@lists.postgresql.org; Mon, 10 Dec 2018 13:21:46 +0000 Received: from tamriel.snowman.net ([96.255.250.162]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gWLVH-0001qL-Sk for pgsql-hackers@postgresql.org; Mon, 10 Dec 2018 13:21:45 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 8E5485F7A3; Mon, 10 Dec 2018 08:21:43 -0500 (EST) Date: Mon, 10 Dec 2018 08:21:43 -0500 From: Stephen Frost To: Michael Paquier Cc: Tom Lane , Postgres hackers , Amit Langote Subject: Re: pg_partition_tree crashes for a non-defined relation Message-ID: <20181210132143.GJ3415@tamriel.snowman.net> References: <20181207010406.GO2407@paquier.xyz> <20181207230540.GA12740@paquier.xyz> <6105.1544243612@sss.pgh.pa.us> <20181208065436.GC1989@paquier.xyz> <20181208134608.GY3415@tamriel.snowman.net> <20181208231507.GA1833@paquier.xyz> <20181208235926.GB1833@paquier.xyz> <20181209174917.GE3415@tamriel.snowman.net> <20181209224221.GB3710@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="acCIYfrzR/XZtXk6" Content-Disposition: inline In-Reply-To: <20181209224221.GB3710@paquier.xyz> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --acCIYfrzR/XZtXk6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Michael Paquier (michael@paquier.xyz) wrote: > On Sun, Dec 09, 2018 at 12:49:18PM -0500, Stephen Frost wrote: > > Looks alright on a quick glance, but shouldn't you also update the > > comment..? >=20 > The comment on HEAD or with the patch is that: > /* Only allow relation types that can appear in partition trees. */ >=20 > This still looks adapted to me. Or would you reword it because "allow" > rather implies that an ERROR is returned? Would you prefer changing it > something like that perhaps: > "Return NULL for relation types that do not appear in partition trees." Yes. Thanks! Stephen --acCIYfrzR/XZtXk6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJcDmhmAAoJEO1sijiDR2RVr2YP/ioZ0aEpqZT/W3o2lYirI9bv GWd89kReCoD4rl77dSCekQhwhoBeKJQheJ1DPC5TvokYIJDuINviKrGPm+7KTaNm 0EQnAibVpvMbFMkymdjS80ag292DYntBDWD7gN+mQ/c+uK+ChcxBRGnIlIM23OZW JsG73xOA1svStuqqdNHxlZ4a5lGcv1zNZG3Cor6mwWZQIJ1Ur71rgqyoPTRE7EFv /vBw59r/8HceNA5Y5HTuiBzRLTCgKv95arm7OZbYmmPlkHe97sArbUf/o+WsIdzT JfgDvUXqemVgMdI+W7fGAlYsqmPmsjtT8LmL9IzCLOeWNnuoPkZpQVUifaqBysZa wvV6rTcLHWuNnRLYw1H48gCusp6OjdmbaBH6R/rHHZBHNeAqorICKgmEx5tnyzeo X73x915U2OpdMF8da5B3yltTSKGvmOPqttS1q3+WlQX7pgWdkEcyfWvXWW0SzJAT hw7RjmewDl7x2xOfBJaI3tAua3iHv5Kc47lbCnTWHLG9Cpf0U/rEjj2ECWMpNq7h 5Ra9AN3gbtf1664lETWRf2FWjoiesdisXugJqc30uh31E9OECQq4NNU6a4Zn4B7P hHQw5OE2xfzSDX+dLdZKJAmcVhjvYmHhDDeHf2TVOe2SOH6mIVpfHQr8JDLo2Yfg 5Bf6R56DQQBHK+Wcm5OE =cYX1 -----END PGP SIGNATURE----- --acCIYfrzR/XZtXk6--