Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gWLzR-0004uJ-IV for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Dec 2018 13:52:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gWLzQ-00058r-7m for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Dec 2018 13:52:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gWLzO-00058k-7q for pgsql-hackers@lists.postgresql.org; Mon, 10 Dec 2018 13:52:52 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gWLzK-0002W9-H0 for pgsql-hackers@postgresql.org; Mon, 10 Dec 2018 13:52:49 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id BB0B3DDC; Mon, 10 Dec 2018 08:52:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 10 Dec 2018 08:52:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=KAls+nCM0MziA/sXbah/vCH5He5 v420Zvp9gS1K1OJM=; b=nw/az7diuB+SYCeiVkK4H2vE6AewobNjZuq7FKD+NMn fiIEPVfIY8XeTngh5uboefh/IcunhJmEmEMPZZxBD+aPn+lHgujydx75FgDSX7S0 FQNUCVY/WsoMegL5Gwq280TqEFzqiSymSPVlWZX3USQsOe33azVuBQqrmkTyFQON 7S3epiec6efXB/gg11+PVgvxJyQPyhQi1/TyIMEVet5X298l/cHLOrv/jVvmT+AW RbodGL6UWr8VxWkGwhXKc+n1zRI2RTIgcQ5NlK2NfXr5QQkJYK7xuCgow3H91np3 DhGUm29ZhcpzQGsxyVT/NDurjvYKXm0t0/u/zBpoFGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=KAls+n CM0MziA/sXbah/vCH5He5v420Zvp9gS1K1OJM=; b=JaX0PN0GQN+F/86LhElq2h wJdKmqOOhCfjV5B7/KCPlr6qr4W+o4rz4nnU80iENiGECuFyEf3OjDrwC09Q8QLi /0RXrxf7tkK3eTeqRPxEsp7mXSXI3LWAr8zwtRP6G91CUL83Se0DJlFEGyYEvCt5 oiouSTxn5uusttELKByrCzyoZ9mOU2YfyK+s9ZruWhQd9JU5CrDpW/MrrSs1XAWm U5atc1mFMvaNvSFErQ1cmX1UCtahF6xB1VnnG7pM0El8SNLfhaK2HK63bPkdrUcL FJydmKuFulmkhaMRaelehYFP+Bsr0BKCcTNqKAH00NPbxtKXdJF3/CMLPojVrmdQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeghedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdejtd dmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgt hhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqne cukfhppeeiuddrvdduhedrudefjedrudeivdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id BA3AF102F7; Mon, 10 Dec 2018 08:52:40 -0500 (EST) Date: Mon, 10 Dec 2018 22:52:37 +0900 From: Michael Paquier To: Stephen Frost Cc: Tom Lane , Postgres hackers , Amit Langote Subject: Re: pg_partition_tree crashes for a non-defined relation Message-ID: <20181210135237.GA1473@paquier.xyz> References: <20181207010406.GO2407@paquier.xyz> <20181207230540.GA12740@paquier.xyz> <6105.1544243612@sss.pgh.pa.us> <20181208065436.GC1989@paquier.xyz> <20181208134608.GY3415@tamriel.snowman.net> <20181208231507.GA1833@paquier.xyz> <20181208235926.GB1833@paquier.xyz> <20181209174917.GE3415@tamriel.snowman.net> <20181209224221.GB3710@paquier.xyz> <20181210132143.GJ3415@tamriel.snowman.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Content-Disposition: inline In-Reply-To: <20181210132143.GJ3415@tamriel.snowman.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --/04w6evG8XlLl3ft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 10, 2018 at 08:21:43AM -0500, Stephen Frost wrote: > * Michael Paquier (michael@paquier.xyz) wrote: >> This still looks adapted to me. Or would you reword it because "allow" >> rather implies that an ERROR is returned? Would you prefer changing it >> something like that perhaps: >> "Return NULL for relation types that do not appear in partition trees." >=20 > Yes. OK. Sure, let's do as you suggest then. I'll wait a couple of days before committing the patch so as if someone has extra comments they have the time to post. So please feel free to comment! -- Michael --/04w6evG8XlLl3ft Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwOb6UACgkQnvQgOdby QH0h9w/8Cqt0NQMQPmBcy3Xji991NvV4Uk0bIQnL0xswk8WkruDbhD4S+g6o/ZVn WIm/s4evK467SnrrdnuaeZBKygMMeiu0c5617YBelexoSTfBlW5UWnVFKkpHtxL1 MboOwx/Kww9w6XXSAUN3d56NdGvB0Ukt0hRe3FUaGWWqUW3XFbdY7h8tU3hzYOj4 jUepQxYReJcmC2/5ZjJkwNewNlgYFk2RulJrV1WliMgKgstRDm/7zXapNhQVwwD0 gr3VkOaoY+DBwJRRRjJk9BOlWNBkY3fKWNnQqbWxxqCMTPlpIGViHo1LZpuyubBR AqrLmdyOE1u7I8XI3mFyQLZVGKqtqs1oU3B+CfmxuZnGMZ6Vi9Pe2W91zcvaOS8J cQrluXRjkzg2OaKVwiSluZvsP88f+1oLqGZ0S9G7bknoazZwJusyK5nFT5sylnlq nGhSUcegDcs7E+e0UYjCHh7cjLNuaqYhHaSbbe03r61SMvxuwnaThp+urAPiCghV 06RNK7Ctt9UCgK1B3t0FoOE8kZHZRmoTP6LoiNyXuwi9+gTKb220OoK2bQ8ARJ5Y 3oXW5t6jP5ysyuyOz0rYKTSbAJwHYI5z/4I+dqums5rAw93DOhJvMcW4uiROFHL5 DTWVOHHntqhYxO5J25p5HTZd7stOMKGzRmrRIo4UO8BaL5TTrfU= =iSqB -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft--