Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZY4H-0001e0-WD for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Dec 2018 09:23:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gZY4G-0003u7-BH for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Dec 2018 09:23:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZY4G-0003u0-4M for pgsql-hackers@lists.postgresql.org; Wed, 19 Dec 2018 09:23:04 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZY4E-0001aq-Nh for pgsql-hackers@lists.postgresql.org; Wed, 19 Dec 2018 09:23:03 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DEEE920DC2; Wed, 19 Dec 2018 04:23:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 19 Dec 2018 04:23:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=Nu4CevBvE7HQxiuSw1Nxy4ETpIt 8aYkPdbXWP9hP0hw=; b=yTRGio3ispAlEDIzQpIIwR4Nd2J1Hsy+jhJJCq0Ihm+ 4h63UMJziENgxZcmrhAMSNSwhpQJY3HgJOyfEyohGNeiTtr55E8wB6kGjfamWwJ6 aI/NMwC6PCsBPmUMFrOoDfBizjkwZHXiv3/o2p/cAu6h1uuFVzzgpHw5j/lHn269 rYQoidMIWMfo1AgnF0KhJm5NHIZxLzW7vRqITXwmt1C8d4HrP6ba0DkEe46tmR2C vj5wlDrEXKqx1thd3RLnesf/KHG2qyLewr31DNqQK5o+UH9FKrqAGA1YZqWQaqc9 YZeCzW48yu6UechJ9Aqet2GJl+zcFN1S4UJn8MO0Aqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Nu4Cev BvE7HQxiuSw1Nxy4ETpIt8aYkPdbXWP9hP0hw=; b=ndHxkZxV73/+c37+SPKqMo M2IihBqhKKjgmkIYlwxY7tpf8kxPch+oOjZlSIXbgoCXZVdVjA2SZUdppGpOYhUF YBYzZkHOIUIIS7RBrBo3EgDHqwNZQX4+vsVF+dvp25t80XZ7We4PSuDs/j4hI2RY mD3IioXGs+JUa6PW86HSY6vDvuXpCy+Ujd2TnC8IQFh04DuNEbwWGZxCzBQS2cK3 6aLDXhhMuzTsMdZpM+l+0irNU+QgG11oRFc1zZjWJbqJ8Iyv0zB1+sfnd9CePvWI qMR8YKydvI4iMLaPLvXbyUn0ZWfPiao1QRWrbLBkkyQtYyME+0+9SZGfq70FiY6A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejtddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdejtd dmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgt hhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqne cukfhppeeiuddrvdduhedrudefjedrudeivdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 01554100BB; Wed, 19 Dec 2018 04:22:57 -0500 (EST) Date: Wed, 19 Dec 2018 18:22:55 +0900 From: Michael Paquier To: Tatsuro Yamada Cc: Kyotaro HORIGUCHI , pgsql-hackers@lists.postgresql.org Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS Message-ID: <20181219092255.GC680@paquier.xyz> References: <20181128.131428.84607836.horiguchi.kyotaro@lab.ntt.co.jp> <54bd214b-d0d3-8654-e71f-45e7b4f979f0@lab.ntt.co.jp> <20181130.154654.56222303.horiguchi.kyotaro@lab.ntt.co.jp> <20181219052705.GD19856@paquier.xyz> <830f4ef8-577e-53ed-4017-adad9c21d2e2@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bKyqfOwhbdpXa4YI" Content-Disposition: inline In-Reply-To: <830f4ef8-577e-53ed-4017-adad9c21d2e2@lab.ntt.co.jp> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --bKyqfOwhbdpXa4YI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 19, 2018 at 04:26:27PM +0900, Tatsuro Yamada wrote: > Yep, I already did that for ALTER INDEX in tab_completion_alter_index_set= _statistics.patch like this: >=20 > + /* ALTER INDEX ALTER COLUMN SET STATISTICS */ > + else if (HeadMatches("ALTER", "INDEX") && TailMatches("SET", "STATIST= ICS")){ > + /* We don't complete after "SET STATISTICS" */ > + } [Wake up, Neo] Okay, then I propose to first extract a patch which does the following things as a first step to simplify the follow-up work: - No completion after "ALTER TABLE/INDEX SET STATISTICS" instead of schemas. - Complete "ALTER INDEX foo ALTER COLUMN SET" with STATISTICS (now this prints parameters, which is annoying). Then let's figure out the details for the rest. -- Michael --bKyqfOwhbdpXa4YI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwaDe8ACgkQnvQgOdby QH3DxRAApluiFvl8X8LFBUKtj1pmhuLPldx7/ThHYyxEViO7xjTTI7JuBAoSJFiN kgOXktjxCQ91BfRqLW0nxZCT7CYt6gzapZrAIHtx6TWCZX/v+WEbcfX8Q5h3SS84 +Y9swRX3DEsjFppRAtEppe6hfaUubbH4YwoaLYabieNfT/j8I2DlyLv58ZAk/UtR 2jpeGuHdRBruDVe7U5ewF3dhTayGHmvNwLovkbnJNWxSrkdAYg6Jfku14gSpY7dN 2bWwIF16b6ih18TVOoYA+TixaDMfguIqAbtiEO35Azv11iKtEq4dDTZTr1fHfZAC i5IdzAzgfiyYRujDJ51nZlgRsUTp0EW+3KgUtSRND+boDni9P8fTJQmtpaoSJa1e EqRBI9KQT9fZ0yAuqogi5vm9owQ3qVMDXVLY2yYaonhYXSnmdQ8k2NniHABKjxLc HLKvSsOqTNaNbh4E4+981BixM+rojKrFXzabTfGNChkboupzRpwt4EOpvAJg+3MI 7J5HU/jftEOVgBL/c+MzrTSri2BoS37bXtd55gSLWsTtRcXAlDT+wtKcQDBuLLdw 3NtkNnmHKZMujUycn7w9zAFBE3JIyQtf7E3K7tWyVtV2v7N59UC0mAPKarsVC6W3 6tXYjSWEZNx8yJhhfT1wwnPu9sgTzxbuzPJ+KTw1CpeTZw5T8eA= =ILHA -----END PGP SIGNATURE----- --bKyqfOwhbdpXa4YI--