Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gark6-0003Dk-UZ for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Dec 2018 00:35:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gark5-0001tl-IJ for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Dec 2018 00:35:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gark3-0001sc-LR for pgsql-hackers@lists.postgresql.org; Sun, 23 Dec 2018 00:35:41 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gark0-0006Vb-AB for pgsql-hackers@postgresql.org; Sun, 23 Dec 2018 00:35:38 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 19FF421B4C; Sat, 22 Dec 2018 19:35:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 22 Dec 2018 19:35:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=LL/bJg3FCtMS0g1C+vY6klXc9EC e64gKImhrLxoD2SA=; b=NyAjNwVnThj09hjTdUE+T8XT0T/Adapn1bC+31W5LdI tkYfhoVmVaoEZPi9rMZuGLSKbEJQI19fct5ZslqjOu6klKNloE2qcQ0a9t51ifDw Chd8Z3fMBkCC7C+9PaW/BEjV0G+R3AzaJWN80noJeFveOgP9SBpHs+jejjpy9ujo cMmunjjRRA5qv6WpcO3IleoB4lxwO1W0XprQforv6xpaedKWuWjZ9pV0KHD6hyF4 4k/ewvZBFYQEby3Gb8Ri66G/o6bqdSUQXM606JmvXq2RRmdjaPWM7ICEPPqlfbWG i52Ev/q1HEQ//jwyIChupXEKzQro0SXS/3R+Becdw1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LL/bJg 3FCtMS0g1C+vY6klXc9ECe64gKImhrLxoD2SA=; b=EZdPgF40m4cxso6P3mYmO3 8FNLfX7d/CU4AvUbBRUNWu4MOqKJKcDwXZ6uwYXGXEef9oYFunAsovcb3Nrby2Cl 8mmEo6WFzMehmRPdlRgEaHi9/ecTGnV66cWMEc9f3IP9SW0Gk6aJoyTX+ChQDRgC 01ja5vQLXTB/BVR+BTUY2D+sTaWl//plCLBZFAdUHAEyd4TKxfZ3slJi2fQf/Fgw y6Usumo/gU2kKUkcKJL5VDhrsLiC0viGU4isDVhFuAtnE4CDmY9hVVzqVv6lt1pn zw5WhNtzXIS1nioaJH+Arer3RJcsbRv4ueEzPJIXPywnaAtkD4KOeevL60BP3O5A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejjedgudekkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlje dtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhi tghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqe enucfkphepiedurddvudehrddufeejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 13A3EE464F; Sat, 22 Dec 2018 19:35:32 -0500 (EST) Date: Sun, 23 Dec 2018 09:35:29 +0900 From: Michael Paquier To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH] Improve tab completion for CREATE TABLE Message-ID: <20181223003529.GA1726@paquier.xyz> References: <20181219050530.GC19856@paquier.xyz> <20181221234856.GG1948@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 22, 2018 at 01:33:23PM +0000, Dagfinn Ilmari Manns=E5ker wrote: > The CREATE and ALTER TABLE documentation calls them storage parameters, > so I've gone for table_storage_parameters in the attached v2 patch. Sold. And committed. >> Reordering them is a good idea, log_autovacuum_min_duration being the >> bad entry. >=20 > toast_tuple_target was also on the wrong side of the toast.* > options. Indeed. -- Michael --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwe2FEACgkQnvQgOdby QH1nnQ/+O/uWtL8ES+CRFvPyfw+gFJlg5Qtx/nYlp8KjpcOBOcvzTLzBW//yRd8z AfMoKb3DKtp/tdCXufdXCo9tYIxp9l35jmF1LetTLn839Y7XdSEpMjTwMujGnTlE sTs95AHeBALzzscJVvG+Pe20cCpvqpZJXsc3FJS4xzpUjsbtzqCDuqXMR+db1Tmr 54xIOvvwN9kJ/3DqqyLHWMBapJT/EMFZxz3zdtYZBmEJ/VH+REnYAkY9Q/+Spkjy LQqYutQqmPaGo80coiUmRo0xoHXrslS0IwIEN/eG0L/bZQz6NqnwXfSj5vHki0vl Bz2tg4vb32OQx5yk+9pjWBbOiPPkHPpzA98yjwCOUd1x90zre+ktHKC7uzMxOkwB hfOl+uhMCW/sas9sFvyCmwtNP88cdv3NYP9F2GtaAThHIV+Rt1Da0fzYLAVAu8eo MSlgZiM4o4VINmyU11DUOvQUzLwzqECz7kcJqBDxO3ZaZ6EM9ChVPboQeZjNhqI6 DN205WzMiYnrMgTgESquNxMreLsBIkDFr9f7aVkG7e1F4+x+V65BuI3Igd8G9G+h Ibt36aUg6S2AzYcBRzHQV5PPYPzBlNqSkp5GqPbzLGIS6xY0Sh3cPqkYgNW8m7sW 7OwZrE1qOEkcc76XG22vn+PCx/QeynCdlIG20CRAcrBWmu4mzLY= =eirS -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--