Date: Wed, 26 Dec 2018 13:50:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Message-ID: <20181226045052.GG2234@paquier.xyz>
References: <20181219052705.GD19856@paquier.xyz>
 <830f4ef8-577e-53ed-4017-adad9c21d2e2@lab.ntt.co.jp>
 <20181219092255.GC680@paquier.xyz>
 <1c45ffd5-0a03-7608-43d8-a828253c0c52@lab.ntt.co.jp>
 <20181220013831.GJ27104@paquier.xyz>
 <9e5c22ec-6071-5495-0265-b7a96afb1a15@lab.ntt.co.jp>
 <bcecaf0e-ab92-8271-6887-da213aea9dac@lab.ntt.co.jp>
 <20181221071300.GA1343@paquier.xyz>
 <5be2c21a-9a15-8200-0c76-6bc936ef69f7@lab.ntt.co.jp>
 <20181225052703.GE2334@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VaKJWhUROU/xPxjb"
Content-Disposition: inline
In-Reply-To: <20181225052703.GE2334@paquier.xyz>
Precedence: bulk


--VaKJWhUROU/xPxjb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 25, 2018 at 02:27:03PM +0900, Michael Paquier wrote:
> Thanks, I have committed this one after making the logic to ignore
> column numbers a bit smarter, one problem being that "ALTER INDEX foo
> ALTER COLUMN" would try to suggest SET STATISTICS directly, which is
> incorrect.  Instead I have tweaked the completion so as COLUMN is
> added after "ALTER INDEX foo ALTER".  This could be completed later
> with the column numbers, in a way similar to what ALTER TABLE does.

Could you rebase the latest patch please?  The latest version sent
does not apply anymore:=20
[1]: https://www.postgresql.org/message-id/bcecaf0e-ab92-8271-6887-da213aea=
9dac@lab.ntt.co.jp
--
Michael

--VaKJWhUROU/xPxjb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwjCKwACgkQnvQgOdby
QH1sbg//aNunOKq+YUW0dZqrtzHYHiKF/+QWX5DKe9hR2zq+SWxijb0Zi0m3bTkR
9IPwmghB2s5qjMuXldrXC8vrpr2kBAjTXAY91/f53J8XyeAgYEgaFaDouNoLmC9M
aSFp7e2sSi6Xe6NBWE/MHVERYVvlW9KTXlq6hqySoEi2fzGWZWiWpo5pFvtIwDpT
G46pSjVLoBaEPjZVNlkSBLepA9iY8I3CO+JF76TkdJuweLpqo/R2ZsxlOFXrmIyr
grW7NUolDXZhoW8rnnJ3PRiNj8t87SewQ6B54wSJe2WFtSC5p1g92nwJj8s8LjSV
UDNeAS5cY1heOVMsTr3tbgL6f8Q5zhly6HHPh+8hSxnaexUIVXejP2RiTns6+mhO
B/Zco0j4EKd4+t1X2+H0q3+NkvOhgW1maM1+mVprMokF8HTkUBQsUQsUl8azMona
jTi8U7n90nuDukfZmZD03AEu+mEHgiQdnWuA6YTRw0Zk9KFQSvQgcrQqDlhLxtg5
/YF9T3yudLNQAGPfDUAhQuyvIAhFCb0SeOD37FMREwf3GZzWYnWXYTkgPUi789C8
g96S5T8/dJn1VjvlVjeeW0X/EekcMBPhjxLeBCtx3VakKYML/MOfiQ5psfNrmDyZ
yuwqpQ3Sz5cM+V2m3OvbDHlCNRgErecjOd4gPTaCwCvfCqJg2Yo=
=0Btf
-----END PGP SIGNATURE-----

--VaKJWhUROU/xPxjb--