Date: Fri, 28 Dec 2018 08:15:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Sergei Kornilov <sk@zsrv.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: could recovery_target_timeline=latest be the default in standby
 mode?
Message-ID: <20181227231514.GD2196@paquier.xyz>
References: <6dd2c23a-4162-8469-410f-bfe146e28c0c@2ndquadrant.com>
 <7495701545389660@sas1-87f9feb8d943.qloud-c.yandex.net>
 <20181221233819.GE1948@paquier.xyz>
 <249bd41d-0385-3038-4394-a42f00e1a045@2ndquadrant.com>
 <6759b48b-5623-b917-0bc8-c4402a3ca338@pgmasters.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bjuZg6miEcdLYP6q"
Content-Disposition: inline
In-Reply-To: <6759b48b-5623-b917-0bc8-c4402a3ca338@pgmasters.net>
Precedence: bulk


--bjuZg6miEcdLYP6q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 27, 2018 at 06:36:23PM +0200, David Steele wrote:
> I like the idea of defaulting to the latest timeline since this is what y=
ou
> want to do most of the time, but I think we'd then need a value for
> following the current timelime, i.e. the one that the backup was taken on
> (which is the current default).
>=20
> [...]
>=20
> I would recommend:
>=20
> 1) Make the default for recovery_target_timeline always be latest.
> 2) Add a new value, current, that replicates the current behavior.

Yes, I was also thinking something among those lines, and the patch is
a bit confusing by linking standby mode with latest timeline.  It
seems to me that switching the default value to "latest" at GUC level
would be the way to go, instead of picking up the TLI from the control
file.  Introducing a new value which maps to the current empty value
may be useful as well, like "control_file"?
--
Michael

--bjuZg6miEcdLYP6q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwlXQIACgkQnvQgOdby
QH3d4g/+Kyx2QPqWGSijQxt3dh+A2huHCjK4wBMUEkPWo9xGYx8wA9EIsWdv1P8j
SIMY3wb2qAhplT5tCbVeE6FfqwL0SULXghcFETg5krw3eTjsHXrL/Cjuslkbs6L8
KO1T5m7sKG4zbIKsXW3mt2dHXxxotr2JRoI4AbSlFPd3a9Z2MegcSYNQ/ykgOGgE
3S/SiTy+KR1sZPvnYnGXzqMQI/1r/LtQi4dydqvAkFBESl737PmV9QtNw43xBMF8
HS19EWRZiXHYeT3niUibpr0UzYdcS/tru9CEMbA+tQte/MKOPAFpagyoiyEwY/C5
Njy0GxQdQdaErRGNYvNMRxDyX21TQKcE94SjotuoQFszFBtOpF2ZMtykyoI958mv
kIjtG3VdNyAqPv1KpywpAJ9CFLRR24cLjK4UVEJiYs4miheJIspBZfsdWmZ1huDq
SM0GNuQc5gxURWPyM9y9r+tIB5qXXCHPhNIeTWi1e5pEyXV5jCLcgbprYTG9t6W4
nVph94mphRcKNnDrgI7H8AmOMw/to0OzY7GgogEIz+8BXEW0XjA0gz6y7z765kqC
fQgAJ4ZZVF/gAr+pL3VrYgwnPqz3yx5bUHGW/rew8i1dUE42d+fJTu/YbG+sApuv
ZqxfxmqLLhisxiGa9Ybu7XZbpdPN9o1rddnTxFFYZGRWJp4owME=
=/2mV
-----END PGP SIGNATURE-----

--bjuZg6miEcdLYP6q--