Date: Fri, 28 Dec 2018 10:30:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>,
	Michael Banck <michael.banck@credativ.de>,
	Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: Offline enabling/disabling of data checksums
Message-ID: <20181228013027.GD3210@paquier.xyz>
References: <20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de>
 <20181221232834.GB1948@paquier.xyz>
 <CABUevEyUaB=Ws=DW-XsBw4ibDXZhQZ8d3WR4485bkmm13kTGVw@mail.gmail.com>
 <348aef85-a967-80d2-7bef-7274909475cf@2ndquadrant.com>
 <20181227232529.GA3210@paquier.xyz>
 <bd6b833b-8250-0810-dfb6-4d8b3e6581b0@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Qrgsu6vtpU/OV/zm"
Content-Disposition: inline
In-Reply-To: <bd6b833b-8250-0810-dfb6-4d8b3e6581b0@2ndquadrant.com>
Precedence: bulk


--Qrgsu6vtpU/OV/zm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 28, 2018 at 01:14:05AM +0100, Tomas Vondra wrote:
> I'm sorry, but I'm not sure I understand the question. Of course, asking
> over at -packagers won't hurt, but my guess is the response will be it's
> not a big deal from the packaging perspective.

(The previous email had an extra "Would"...  Sorry.)
Let's ask those folks then.

> What do you mean by "control" here? Dealing with checksum failures, or
> some additional capabilities?

What I am referring to here is the possibility to enable, disable and
check checksums for an online cluster.  I am not sure what kind of
tooling able to do chirurgy at page level would make sense.  Once a
checksum is corrupted a user knows about a problem, which mainly needs
a human lookup.

> I'm not sure data checksums are particularly great evidence. For example
> with the recent fsync issues, we might have ended with partial writes
> (and thus invalid checksums). The OS migh have even told us about the
> failure, but we've gracefully ignored it. So I'm afraid data checksums
> are not a particularly great proof it's not our fault.

Sure, they are not a solution to all problems.  Still they give hints
before the problem spreads, and sometimes by looking at one corrupted
page by yourself one can see if the data fetched from disk comes from
Postgres or not (say inspecting the page header with pageinspect,
etc.).
--
Michael

--Qrgsu6vtpU/OV/zm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwlfLMACgkQnvQgOdby
QH00Fw//d41P9DOQcdxcSkWIaQo6ryT93tsYlDO4MMaKapqw11ciMw8atvK72paF
qn/iUpPO3OQ4rYYw/H1+4FKP/S/f8KpQ1qqb85CXdZ0vWcCuENdSADDjawprB/Ah
fdGhXZnJ56W9L9dOTb5IGOVZrROdPOhvRCVGbyuOWXlw2pEjN9XK9phJ/uxQgInh
Z8Wn0YwF/pYZvhaCSjE9LsJLMtT2QExWH1d/XehQ0YgQFkQBJHHcTBgI/zctwnIg
UP+ij6bVXymU8PL7vKI/7KO8ZGJLR7wd9DjREbyt3uUr1F9UULIgXBx87LT0IAxe
m4pMgO5jtafH+jFlqRuk3DIFEaldZNF8023GSlmx8Q+E9J0mt4Z8CS8n8OOa/Zby
X61btLm5SzyeMpe3FwtP/j+rxK3pX/4bGAHiCOgdupgvZrEm08zK0ysEgikHZXHc
g1ihS/zTpWvOOnPet+EoJw8zZQIKXpNQY/KQAJqCxJoPxaRh6SCb7MZk8YUYLwtD
7DeHVsCowds8XxEo4/dcouVeKKLC/iwTNh8kZ51Mln7DY5ut7b8przdF5Ua5nMuf
kgwI1GAuorolLhqejOsWCHqFMFa/69MzAO01TAz/caKjX7jGt0VJL7qILW+rhXCx
dnuk1Skkp6+2UomI7343vu5VtXwkoX5YNMTLRoQfCqgBpUAx0tk=
=Zoua
-----END PGP SIGNATURE-----

--Qrgsu6vtpU/OV/zm--