Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gch9x-0000Ti-As for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Dec 2018 01:41:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gch9v-0002nB-IT for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Dec 2018 01:41:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gch9v-0002n0-Aj for pgsql-hackers@lists.postgresql.org; Fri, 28 Dec 2018 01:41:55 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gch9o-0003Je-Vq for pgsql-hackers@postgresql.org; Fri, 28 Dec 2018 01:41:54 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B55CD21B5A; Thu, 27 Dec 2018 20:41:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 27 Dec 2018 20:41:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=YQdTwgJFSpX0JWtnCb1zXN3hTT/ yvVHH+A43T6w5dyc=; b=Q+H2yaTS8tLbEbNuwiRbldZb340I1f54d0vzR47zifZ 8KIT3ACiN83eE4HbYkESKFjnYlVTSkL0Sowk9hXCl2S8vw7/9atD473LqUY9Gwuw k+JxN7T0z/+eNgKdztbz27m4smlzPAVMsGjbkbmYAUBUuYVeiNPmOKdkU4WGigbh BePK88+8sKFI435Pfg9IELtBqUiWLiabF64evBXvYbyMwBDMZdcfNeseQ40oTUeG a2VTBIM5N1myzDvSaEn8kFmV+rKN4ko3J+yz3yx5WaEV0D7yVhggHzCFk2H4JfzI BTCyVo7aMvsdFFvX8pEmYn7KQO30Bk1L5F6blRag/pQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=YQdTwg JFSpX0JWtnCb1zXN3hTT/yvVHH+A43T6w5dyc=; b=xdT9Sx3GSIvnzIPKWkJqEZ JB7dxsCVymLaR0Rx7sLiiyrdwbUQPylDp6eJUz4ufUg6YhNf9iv2LdY9XvIL2qiD NZ1qLWz8D70scPbawgM1uSmFxNERUOMuzQ5rebN0qHbGC1bzgRxNTVbXg6fyuQtY RLch3AVbCwcpuIRRWHNDj0q8WDfXal2ndOiKfTfYkQfTeBEQmBrYqxbhqJQhGNRz TLA5CYMBUyrTleJismAoLlDDm10XL29MLolGgdH9Oo+J6ORdktS06b5DytRMUKji GzPmRGb9mCpzsmcNxsffqdaUXw0fMn9eugdp9rP9d/fbFgRRu4fYB6pg/4m6XhYw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrtdeggdefkeculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepuddukedrvdeguddrvdehtddrjeeinecurfgrrhgr mhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (mp76f1fa4c.ap.nuro.jp [118.241.250.76]) by mail.messagingengine.com (Postfix) with ESMTPA id A6726E4384; Thu, 27 Dec 2018 20:41:45 -0500 (EST) Date: Fri, 28 Dec 2018 10:41:43 +0900 From: Michael Paquier To: Tom Lane Cc: Ian Barwick , "pgsql-hackers@postgresql.org" Subject: Re: Minor comment fix for pg_config_manual.h Message-ID: <20181228014143.GE3210@paquier.xyz> References: <08534fc6-119a-c498-254e-d5acc4e6bf85@2ndquadrant.com> <20181224085726.GC2764@paquier.xyz> <31639.1545751350@sss.pgh.pa.us> <20181226003657.GA2234@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fWddYNRDgTk9wQGZ" Content-Disposition: inline In-Reply-To: <20181226003657.GA2234@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --fWddYNRDgTk9wQGZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote: > like the attached perhaps? At the same time I am thinking about > reformulating the second sentence as well.. > > /* > - * This is default value for wal_segment_size to be used at initdb when run > - * without --walsegsize option. Must be a valid segment size. > + * This is the default value for wal_segment_size to be used when initdb is run > + * without the --wal-segsize option. It must be a valid segment size. > */ > #define DEFAULT_XLOG_SEG_SIZE (16*1024*1024) So, any objections with this change? If somebody has a better wording, please feel free to chime in. -- Michael --fWddYNRDgTk9wQGZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwlf1cACgkQnvQgOdby QH1I0w/9FByXUUB7CQNIIjyYb8tyYYT+qhadFmijYo4ROhnZyf3rOXBLpG8010bI peNTDVbGGMJChW8uZPAuMpgHGODXtO4/ksq6ZXmEYaryW0mkkavkbFiJx2jWTpws 1JlXEwZTU/83vG/pTmjqO5CCTXqvhQk7LNqkWDx6gduvh9bmH0quE1T7IcwIQmlw OH2qUzKKavyfz1DNuix0KaQx0TuUv1TlRlKap16WyptOq66c1RX/2U1yoQGlsgl2 y3HbQw3ZAXv7X3FtiScqFy46fCuznC8kTL+lI4D7jZnEgAtToSotApOKOWHR/1sY WUVWxbZ5mhXewQNos4gl09jArBrEmFmjssSHnL8SZaWz44mj7/AD5oVjM0sKlvg4 SZgj9uWILnTii0VljqUewCTa/2ZWvY1JIS6KldEMed6tVaJxZ+7dij9SOOIc5n7N tsK6ywTlzIL6aotAfbLs8Os+sY4/pDzFPWgJvABJjeQfkdoYyoKMPGxkRxqa3bMW jBdL0QkKBggwAxM0EBlZ+LZQVstHWkOThIn+FOeshqIN9XaS1bHoiBrYNQJUDGwG FL29yrY37rE1z11EfcWdiPDmwPKY+gaAwC1bvABuFl2MvELGF8CbQwE4+lZcFUrf EFMbWeSK0SuKFBUukEKI5T019djdBU5cmckE5D1Ly9aazIhZYOg= =Pg2w -----END PGP SIGNATURE----- --fWddYNRDgTk9wQGZ--