Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gciT8-000522-Fm for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Dec 2018 03:05:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gciT6-00069Z-12 for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Dec 2018 03:05:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gciT5-00067s-LC for pgsql-hackers@lists.postgresql.org; Fri, 28 Dec 2018 03:05:47 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gciSx-00057d-6X for pgsql-hackers@lists.postgresql.org; Fri, 28 Dec 2018 03:05:46 +0000 Received: by mail-qt1-x844.google.com with SMTP id d19so22187214qtq.9 for ; Thu, 27 Dec 2018 19:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=KsZP7jZyKWRQQJxk5yNlcoMS1aSS9i4GttLpoO9pA7E=; b=D238M9gLXxEtCezoPOZEYCy6aFqx1THrQ0jBEG7nkSGC/lsdZLdVvUEECdlgIio7s2 Qn+DtFrAus5xGhBzJ2w55DzJG3+I5DhUQzO5abOQk5V7dvto8hZxVYfVcsjaPJPP9FHL zxnvRh5BnnhQKYZKA+rFuVeIIrgW86uubbyGA4+RsYVLRv+kt302/WaTjwuWmq3XjJjN XB2NIP2fiqS/Um9Yx15l1oxAIp3QTVMYl6boHsy9F3ia4MqNf9eaHHLByPfldTBXgZzJ 3pthb72X9d29a5EvQmtp7XmRV+pLgvxhXiJLM7suteTzo9yVTbGw0fgNLGNqklCWU+i+ dG/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=KsZP7jZyKWRQQJxk5yNlcoMS1aSS9i4GttLpoO9pA7E=; b=cbozZi/4ZEdvIMrFtNFq7a8fKEJZgBzmlzZ7C+BEVluv4nEUy4AAVRUMXc6RY4w0dQ Pmm2q+13wC1+ORo9nCT7NoLGJZttsH73OpcEdPz9kJd9IfdzeN4y3bLCVEPvga/3wJL8 uCDpuFtt14LCu7CFye2yrex65BcYLHLBVSjVMfkhTjfwM//SackmbDD9iR0OWZAgUrxr 7GTQDuUizjs3vMwPSzBj7UWbnwzgdxbF5A2rMSpP+o58iPkgZVClV+rkNew+qIz2zqqy 76TZoHJpw9/3CcqoAMczVnEVqPA0l++aJzJDTDTkAg7rO7tiRZMuNsMwMspdL7P3ueRm T72Q== X-Gm-Message-State: AJcUukfNT43mspIeOzuRDyRXvVrILTj3g+XmQNNlKK46d/BpwBSNqKKF DrQaHdIUyl/Y9p/QqUHkJfdQAQ== X-Google-Smtp-Source: ALg8bN5D8pHwvCJYXgITXfJlUgDvP94toQ6HR/VWOakSRwdZAXujd51a2+uATbFmBR8JUPdi54dfKA== X-Received: by 2002:ac8:149:: with SMTP id f9mr24385500qtg.221.1545966336548; Thu, 27 Dec 2018 19:05:36 -0800 (PST) Received: from alvin.alvh.no-ip.org ([201.186.80.67]) by smtp.gmail.com with ESMTPSA id d78sm13368321qke.94.2018.12.27.19.05.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 19:05:35 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 3CEF79A0; Fri, 28 Dec 2018 00:05:34 -0300 (-03) Date: Fri, 28 Dec 2018 00:05:34 -0300 From: Alvaro Herrera To: Michael Paquier Cc: "Tsunakawa, Takayuki" , Tom Lane , Robert Haas , PostgreSQL Hackers Subject: Re: removal of dangling temp tables Message-ID: <201812280305.7us3unrlehxu@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181227225654.GA2196@paquier.xyz> User-Agent: NeoMutt/20180716-1013-2c1e88 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2018-Dec-28, Michael Paquier wrote: > On Thu, Dec 27, 2018 at 04:30:21PM -0300, Alvaro Herrera wrote: > > We allow structs to receive new members at the end of the struct, since > > this doesn't affect the offset of existing members; thus code already > > compiled with the previous struct definition does not break. AFAICS > > there is no danger in backpatching that, moving that struct member at > > the end of the struct. > > Sure. Now this comes to PGPROC, which I am not sure we can say is > never manipulated as an array. The server code allocates arrays, but that's fine because that code is recompiled. Extensions only pass pointers around -- they don't create any additional arrays. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services