Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gciy4-00073b-MJ for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Dec 2018 03:37:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gciy3-0007j7-FJ for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Dec 2018 03:37:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gciy3-0007ir-8E for pgsql-hackers@lists.postgresql.org; Fri, 28 Dec 2018 03:37:47 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gciy0-0005rc-Lf for pgsql-hackers@postgresql.org; Fri, 28 Dec 2018 03:37:46 +0000 Received: by mail-qk1-x744.google.com with SMTP id o125so11975756qkf.3 for ; Thu, 27 Dec 2018 19:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=VO1bawg2iKvFzs129SculzNi508oJIRRXkjoEn7svCw=; b=NP2WgXGsXZQXypbcvPAwuOU9DAfnIDQQWlOYmESt7QX10OVscVPcec6XSEONJFw2sY HTvVslc7S0PykDjxwY2Kar2ZrCWi1qm9hY83DV9cMnHeUqX4c+J6U1KogJxj51XZawWH 1F6Opo1LwJIPR5xsATdP4Cxi20nRXVJQ/Ufqpz9BqWbl75Q4+Gm2eDfJ8PfThHBWACxo 4NVTSpcYuG7a28LKSyyWP1UqLgrL1b7/8sA8HIMiSMuwZ9jge+I1ig7nAgBuj9MclJVj MS2hUV5gosquZUGS8WAInUQWPL7+4pAOTzuGKZEAOif3Q23ex69WMYZV2eOJLbKbk26t e29Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VO1bawg2iKvFzs129SculzNi508oJIRRXkjoEn7svCw=; b=C4u9tEzGa1TcnXIODVsNuj+m7gXTJ2rBYthKok/M03VmgXabUE3ltCZXRbd1ipoxGG F8u44KZ9HGiMHHeSPY8F82ZSFmjOr/3XHTn2HraRWQvHEUbYPSaUaLWTStqa4hXunKGQ Q0cwFZNLIyXCegviYBf2VTnt/ZA2eC0FfAfnvbdYBdYXYWyAYVa5eHUJs5ajCBFyoYoW 6a5KuQlSqDgF0xiPtt1SR4acg5G4tRgAhY2tp4EnRhFR0a4r/6Pirs5Ejb4+AvbSbAp8 8qET7wV8+YH2wNc0/NQl1Oe8WrjtL9dRlghdIOSTcwniVmZ8NIRdh1ZnaSuh1lla0qv3 IoKQ== X-Gm-Message-State: AJcUukfqkyd142XmsmvP0eh2QIJfWPDLeoXw4yp8asNuWF7D2DjhvuUx OxzHR2BskZMPM8p61K6xvN/ldssXtbwL+Q== X-Google-Smtp-Source: ALg8bN7JvdniwQ0Eg+UNkJnDuzS9lQpYSr1cPRw6hO2k5CjlhbvqnC2DUgfjllnRHbriK0qZd4pZig== X-Received: by 2002:a37:945:: with SMTP id 66mr7128792qkj.123.1545968263081; Thu, 27 Dec 2018 19:37:43 -0800 (PST) Received: from alvin.alvh.no-ip.org ([201.186.80.67]) by smtp.gmail.com with ESMTPSA id c17sm20994310qtb.14.2018.12.27.19.37.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 19:37:42 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 2A19670D; Fri, 28 Dec 2018 00:37:41 -0300 (-03) Date: Fri, 28 Dec 2018 00:37:41 -0300 From: Alvaro Herrera To: Michael Paquier Cc: Tom Lane , Ian Barwick , "pgsql-hackers@postgresql.org" Subject: Re: Minor comment fix for pg_config_manual.h Message-ID: <201812280337.4a5kfhhzeje3@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181228014143.GE3210@paquier.xyz> User-Agent: NeoMutt/20180716-1013-2c1e88 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2018-Dec-28, Michael Paquier wrote: > On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote: > > like the attached perhaps? At the same time I am thinking about > > reformulating the second sentence as well.. > > > > /* > > - * This is default value for wal_segment_size to be used at initdb when run > > - * without --walsegsize option. Must be a valid segment size. > > + * This is the default value for wal_segment_size to be used when initdb is run > > + * without the --wal-segsize option. It must be a valid segment size. > > */ > > #define DEFAULT_XLOG_SEG_SIZE (16*1024*1024) > > So, any objections with this change? If somebody has a better > wording, please feel free to chime in. Looks good to me. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services