Date: Fri, 28 Dec 2018 13:23:58 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: removal of dangling temp tables
Message-ID: <201812281623.qlyp5nygu3pt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <201812281325.g6m75ehwqq4p@alvherre.pgsql>
User-Agent: NeoMutt/20180716-1013-2c1e88
Precedence: bulk

On 2018-Dec-28, Alvaro Herrera wrote:

> On 2018-Dec-28, Michael Paquier wrote:
> 
> > On Fri, Dec 28, 2018 at 12:05:34AM -0300, Alvaro Herrera wrote:
> > > The server code allocates arrays, but that's fine because that code is
> > > recompiled.  Extensions only pass pointers around -- they don't create
> > > any additional arrays.
> > 
> > There are many exotic extensions which could be using sizeof(PGPROC)
> > as that's a popular structure,
> 
> Can you show one instance of this?

I looked at 
https://github.com/postgrespro/pg_wait_sampling/blob/master/pg_wait_sampling.c
https://github.com/citusdata/citus/search?q=pgproc&unscoped_q=pgproc

and skimmed a few others can't find any instance where the full struct
is used, as opposed to just a pointer to it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services