Date: Fri, 28 Dec 2018 14:52:24 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: rewrite ExecPartitionCheckEmitError
Message-ID: <201812281752.evicricdva5e@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+TgmobkopYEY3nwjuCBWyWe3ADd1QDkGz0EB1suagXN_qQSUw@mail.gmail.com>
User-Agent: NeoMutt/20180716-1013-2c1e88
Precedence: bulk

On 2018-Dec-07, Robert Haas wrote:

> On Thu, Dec 6, 2018 at 5:22 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > Just on cleanliness grounds, I propose to rewrite the function in
> > $SUBJECT.  I came across this while reviewing some already-committed
> > patch for partition pruning, and it's been sitting in my laptop ever
> > since.
> >
> > I think the current coding is too convoluted and hard to follow.  The
> > patch makes it much simpler (IMO).
> 
> I don't really think this is an improvement, but the only part I
> really dislike is s/val_desc/valdsc/.  That is surely not an
> improvement in readability.

Point taken; pushed with that change.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services