From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: David Steele <david@pgmasters.net>, Robert Haas <robertmhaas@gmail.com>,
        David Fetter <david@fetter.org>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Magnus Hagander <magnus@hagander.net>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        Julian Markwort <julian.markwort@uni-muenster.de>,
        Stephen Frost <sfrost@snowman.net>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
        Valery Popov <v.popov@postgrespro.ru>
Subject: Re: Password identifiers, protocol aging and SCRAM protocol
In-reply-to: 
 <CAB7nPqRsUR09-eqmc5RVv8rvBk0nj4PctxL6YkKL73Tc47hSLg@mail.gmail.com>
References: 
 <CAB7nPqSL_V+0nD5i-XH_x1o5HTt2bT53vVwPUTHz8YT0hYRoPg@mail.gmail.com>
 <20160720181257.GA686053@alvherre.pgsql> <20160720202524.GA16111@fetter.org>
 <CAB7nPqQwR+93uLozt-CYiDnq1WPQYLYjZ5NMWs_3Pthu1pWFQQ@mail.gmail.com>
 <CA+TgmoZMn67CUgUxTD2vFgp7oHWH9qCHRUWebY6OSfSRVG5a_g@mail.gmail.com>
 <88f35221-2abd-6a31-a75d-28a3dc3a5b30@pgmasters.net>
 <29704.1469122290@sss.pgh.pa.us>
 <CAB7nPqRp74T70QELi8M8LHmMPXSzzBHwc3orAsQFuGbxB4o0HQ@mail.gmail.com>
 <19611.1469144923@sss.pgh.pa.us>
 <CAB7nPqRsUR09-eqmc5RVv8rvBk0nj4PctxL6YkKL73Tc47hSLg@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Fri, 22 Jul 2016 08:57:07 +0900"
Date: Thu, 21 Jul 2016 20:02:28 -0400
Message-ID: <20190.1469145748@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> On Fri, Jul 22, 2016 at 8:48 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm confused.  We need that code in both libpq and backend, no?
>> src/common is the place for stuff of that description.

> Not necessarily. src/interfaces/libpq/Makefile uses a set of files
> like md5.c which is located in the backend code and directly compiles
> libpq.so with them, so one possibility would be to do the same for
> sha.c: locate the file in src/backend/libpq/ and then fetch the file
> directly when compiling libpq's shared library.

Meh.  That seems like a hack left over from before we had src/common.

Having said that, src/interfaces/libpq/ does have some special
requirements, because it needs the code compiled with -fpic (on most
hardware), which means it can't just use the client-side libpgcommon.a
builds.  So maybe it's not worth improving this.

> One thing about my current set of patches is that I have begun adding
> files from src/common/ to libpq's list of files. As that would be new
> I am wondering if I should avoid doing so.

Well, it could link source files from there just as easily as from the
backend.  Not object files, though.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers