Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1geThI-0003Uz-60 for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Jan 2019 23:43:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1geTgG-0005ij-Rj for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Jan 2019 23:42:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1geTgG-0005iT-EX for pgsql-hackers@lists.postgresql.org; Tue, 01 Jan 2019 23:42:40 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1geTg8-0003E9-RI for pgsql-hackers@postgresql.org; Tue, 01 Jan 2019 23:42:39 +0000 Received: by mail-qt1-x841.google.com with SMTP id r14so32104362qtp.1 for ; Tue, 01 Jan 2019 15:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=S/dPBE/kjtyInIJ6ZrLILU2i9ItlZhRUAzXrE3K4IzU=; b=dItzjU9FOVrG3xHNX2ql6cse/2r7cFyaEGs8joe0CYIQCw7yy8pJoh+Hw4MpW7NVss qRoToxvYwYj/usL93wdFcSSDBko3kx4CtMDjtTo7FXh/lcbGTaDtT5RIv9gjkyYijsVJ /IICLu4w9c3Irc5qto21W1rMU0XdA0MqsZi0YtwE//eL9Efbq5IVZgI7af2l1eW+bX1W YVSQ7VYgwIEKvZWAYcqf9fLRXLxg67UbpOLiM6ufMpUXyfz1OQDjEsqWEbJ+aUlwy0NE wNHAGY1VGsB3skSNZk4JfIIl1YDooTl8IyErAVkIzotoC4JwnFnevsGlJn3bH3qbjR7n zvZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=S/dPBE/kjtyInIJ6ZrLILU2i9ItlZhRUAzXrE3K4IzU=; b=TVUp1cHV2nu30YCLlSm8DQ/e42PfIRK/nHL3bPhkip4F6zWdSyk1QZfLsumBLxe2AO qLznNzWHetsnooA/080scTRrZWsKxlz52rihBWLozpg5IkyouwMsS9i94F03HwKyAxDA pVYUdr2lJEJoQsu6saFk8KuiGeuuKR8ucyjmHclclIscdSBsvW4KC9S2vJ+jSKtjAOsD SyfVxVks9Uh2VgpQNBJjBxqguF7elzaUb3nUXnTz36MeaOb9GtWpYVFh1IEvbycOGM/h 9Ny7Vmh35DAlK/CNWlh2GZGyMZLiTqjwQkomVBcryqtAPEix9C7spqGcO2DyfXDdOeIV bHdQ== X-Gm-Message-State: AA+aEWZEca1VODYFmJdeJTDb20wI5iBYdhCQt83ELcNlauQZWk+cqOcc ZRDBxPtZkBhlEMheXFyFGF9bEg== X-Google-Smtp-Source: AFSGD/WHfRK4h17GWLcu+xh63RQKd/vY6muGxRK1L4pGw2g5qipx8IIx/UAk5JigC16cBIuLQb21IQ== X-Received: by 2002:ac8:7a8d:: with SMTP id x13mr41094743qtr.357.1546386150082; Tue, 01 Jan 2019 15:42:30 -0800 (PST) Received: from alvin.alvh.no-ip.org ([201.186.80.67]) by smtp.gmail.com with ESMTPSA id q5sm37728525qtq.20.2019.01.01.15.42.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Jan 2019 15:42:28 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id D1E2B9A0; Tue, 1 Jan 2019 20:42:26 -0300 (-03) Date: Tue, 1 Jan 2019 20:42:26 -0300 From: Alvaro Herrera To: Tomas Vondra Cc: Andres Freund , Kyotaro HORIGUCHI , ah@cybertec.at, magnus@hagander.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org Subject: Re: shared-memory based stats collector Message-ID: <201901012342.rc2qe2a7ymyw@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54232a9d-0bba-2bc2-6ed2-70598372459c@2ndquadrant.com> User-Agent: NeoMutt/20180716-1013-2c1e88 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Jan-01, Tomas Vondra wrote: > I agree it's a sensitive part of the code, so additional reviews would > be welcome of course. I've done as much review and testing as possible, > and overall it seems in a fairly good shape. Do you have any particular > concerns / ideas what to look for? I haven't reviewed this patch thoroughly. Shall we do a triage run over the complete commitfest to determine the highest priority items that we should put extra effort into reviewing? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services