Date: Sat, 5 Jan 2019 12:42:47 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Use atexit() in initdb and pg_basebackup
Message-ID: <201901051542.macmepgkz3zr@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3d072ada-198a-f5ee-8769-bc51823d4f19@2ndquadrant.com>
User-Agent: NeoMutt/20180716-1013-2c1e88
Precedence: bulk

On 2019-Jan-05, Peter Eisentraut wrote:

> On 04/01/2019 20:35, Alvaro Herrera wrote:

> >> +	/* prevent cleanup */
> >> +	made_new_pgdata = found_existing_pgdata = made_new_xlogdir = found_existing_xlogdir = false;
> >> +
> >>  	return 0;
> >>  }
> > 
> > This is a bit ugly, but meh.
> 
> Yeah.  Actually, we already have a solution of this in pg_basebackup,
> with a bool success variable.  I rewrote it like that.  At least it's
> better for uniformity.

Ah, yeah, much better, LGTM.

> I also added an atexit() conversion in isolationtester.  It's mostly the
> same thing.

LGTM in a quick eyeball.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services