Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjrCG-0003FF-H2 for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Jan 2019 19:49:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gjrBH-0007Hd-0Z for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Jan 2019 19:48:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjrBG-0007Da-Jr for pgsql-hackers@lists.postgresql.org; Wed, 16 Jan 2019 19:48:54 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gjqvR-0005ED-W4 for pgsql-hackers@postgresql.org; Wed, 16 Jan 2019 19:32:36 +0000 Received: by mail-qk1-x742.google.com with SMTP id q8so4555979qke.1 for ; Wed, 16 Jan 2019 11:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=kLsTX9dOK6W9EfBlp8itxAXsUGwivSyc+XgPEMzIGhw=; b=KDUhzstSKFhDjpswcBjNnNzTpSyb+h2lmh6XRM3o7F/9QDioqa0EB3vj7NhRH2kRlq Clt4BdLhMFmBjk1kKPXVWfzepcZUkDyk+HUyofZK0u2IfoNibuYtU7H+jiVz/xBpEYrg yOMhN7lFwkc+Gx4uGc6zAkDxZNL/yzwJL9XM3VzgM8YtihU6IHfjpILdheVj/i1Cps+4 C5lZCM3mRDpcAOzyUeXuPbd6tMawLhb3ZLyGn3PtIzFxl6CFvWGBZdsKw3LgRSHcN7Yk s1GpQZplZ3N1U46awSMJEDJ25HSmapUFyXjom0+zhsojWZlQpRGq0BqqZ73BOsncRV9a 7GtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kLsTX9dOK6W9EfBlp8itxAXsUGwivSyc+XgPEMzIGhw=; b=TTiVHCzyJl+Fgr3uHoktrAmNAcm//FrIRpr8qr6bc9MFSGL54UyC90vlQbNll7+FSt jwkcPuQa4R7iCXMc3earRFoh/brohz505yRwC/c7xw2RGzcVVQvXqpcCjnBxGSp8lwo7 Mqlnwq3VqMUY25qPKf2tU+P/HdDUwlHZ5o1ipKGx/0aR0y+I5E9xioi+tIjiuJo7AOqy glRy3jKuH2yr5lrROzo39CL6g+z12fNVbrqR/9pH4zzFNoTesWmQ21Eh8eiFWrmIgRbh 7n53IHxlT38bMB8deiZ8dSYHFNvp75vcQ8uHREAkOnvUKRrljmTlOaVuy5eUCAop6ctW RLlg== X-Gm-Message-State: AJcUukfQ3hCtglISqK7/JIxxgHBnPGyxbFeabufY8q0enIHPAlCdjgkp gMizXD7uR6YMbtAvES2iyh2zOw== X-Google-Smtp-Source: ALg8bN4KFQ2DfG+jVklQGzXo0KbAOB/0CIjKVdrqlGwQovEkjc8VQRhJH2fmu6bRIjYjOzbe/Dmy/w== X-Received: by 2002:a37:9906:: with SMTP id b6mr7976647qke.208.1547667150812; Wed, 16 Jan 2019 11:32:30 -0800 (PST) Received: from alvin.alvh.no-ip.org ([190.217.219.6]) by smtp.gmail.com with ESMTPSA id x202sm44581235qka.67.2019.01.16.11.32.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jan 2019 11:32:30 -0800 (PST) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 6804E657; Wed, 16 Jan 2019 16:32:20 -0300 (-03) Date: Wed, 16 Jan 2019 16:32:20 -0300 From: Alvaro Herrera To: Amit Langote Cc: David Rowley , Amit Langote , "Imai, Yoshikazu" , Pg Hackers Subject: Re: speeding up planning with partitions Message-ID: <201901161932.c6oxfxckbnyo@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7478e768-619d-00d2-b47c-de57e9fea2d7@lab.ntt.co.jp> User-Agent: NeoMutt/20180716-1013-2c1e88 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Jan-11, Amit Langote wrote: > Looking around a bit more, I started thinking even build_child_join_sjinfo > doesn't belong in appendinfo.c (just to be clear, it was defined in > prepunion.c before this commit), so maybe we should move it to joinrels.c > and instead export adjust_child_relids that's required by it from > appendinfo.c. There's already adjust_child_relids_multilevel in > appendinfo.h, so having adjust_child_relids next to it isn't too bad. At > least not as bad as appendinfo.c exporting build_child_join_sjinfo for > joinrels.c to use. OK, pushed, thanks. I may have caused merge conflicts with the rest of the series, because I reordered some functions -- sorry about that. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services