Date: Fri, 18 Jan 2019 16:27:38 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: =?utf-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez@carto.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl
 special character
Message-ID: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAM6_UM7dm3LyExoVF2me2dCijd-e3o0oWEg3jKDrmg-b5x3Z4A@mail.gmail.com>
User-Agent: NeoMutt/20180716-1013-2c1e88
Precedence: bulk

On 2019-Jan-18, Raúl Marín Rodríguez wrote:

> Hi,
> 
> > Fun.  But is that really the only place that fails?
> 
> Yes, other than this it builds flawlessly.
> 
> > This does not look right to me: glob has a different set of special
> > characters than regexes, no?
> 
> The issue itself manifests in the grep call, not in glob, but I tried
> using `quotemeta` only for grep without success (probably because I didn't
> know how to properly call `quotemeta` over @logs.

Perhaps you can do
   @quoted = map { quotemeta($_) } @logs;

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services