Date: Sat, 19 Jan 2019 16:54:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andreas Karlsson <andreas@proxel.se>
Cc: Sergei Kornilov <sk@zsrv.org>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Michael Paquier <michael.paquier@gmail.com>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
	Stephen Frost <sfrost@snowman.net>,
	Craig Ringer <craig@2ndquadrant.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
Message-ID: <20190119075459.GF3306@paquier.xyz>
References: <20180201062158.GD6398@paquier.xyz>
 <60052986-956b-4478-45ed-8bd119e9b9cf@2ndquadrant.com>
 <10797471544200851@myt3-964eae3a5b05.qloud-c.yandex.net>
 <93a3d2fb-43a0-cf14-e8d0-d2c3195c1e5b@2ndquadrant.com>
 <20486991544381729@iva5-d3020dc3459d.qloud-c.yandex.net>
 <f57aa1f7-cc66-7fdb-27a8-7eedbd1467c7@2ndquadrant.com>
 <36712441546604286@sas1-890ba5c2334a.qloud-c.yandex.net>
 <20190116082705.GB2550@paquier.xyz>
 <c11e1832-3c3e-c8a2-cdf4-3abc7b7ffdde@proxel.se>
 <20190117051101.GD2036@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="w2JjAQZceEVGylhD"
Content-Disposition: inline
In-Reply-To: <20190117051101.GD2036@paquier.xyz>
Precedence: bulk


--w2JjAQZceEVGylhD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 17, 2019 at 02:11:01PM +0900, Michael Paquier wrote:
> Okay, I have begun digging into the patch, and extracted for now two
> things which can be refactored first, giving a total of three patches:
> - 0001, which creates WaitForOlderSnapshots to snapmgr.c.  I think
> that this can be useful for external extensions to have a process wait
> for snapshots older than a minimum threshold hold by other
> transactions.
> - 0002, which moves the concurrent index build into its own routine,
> index_build_concurrent().  At the same time, index_build() has a
> isprimary argument which is not used, so let's remove it.  This
> simplifies a bit the refactoring as well.
> - 0003 is the core patch, realigned with the rest, fixing some typos I
> found on the way.

Are there any objections if I commit 0001?  Introducing
WaitForOlderSnapshots() is quite independent from the rest, and the
refactoring is obvious.  For 0002, I am still not 100% sure if
index_build_concurrent() is the best interface but I am planning to
look more at this stuff next week, particularly the drop portion which
needs more work.
--
Michael

--w2JjAQZceEVGylhD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlxC19IACgkQnvQgOdby
QH3JDg/+JWB/k5iy9QWLR0dKAfciUP9iAEd1/K693lCHiN1m+KYPVdONDPVrjXZj
5xBHjjELeyhBlf4Cok1AhjW4ZjJVtIqFa2UHOSc41lLQG+aPkjiBxBHfi9vFsNIm
C9/jixBYfFYmtSglz1htnjjXJbN2AhyZ8e08qkzpf/AaCaoKDPRtFyeTxYR/jGDM
NHcsAL0dnnSn5CeMF2/UrhOo9xvqynC9Khi05/ifqTv/R9gt5VOD5LEVSAOUgMEj
0BZnamqBs+CywARcsUuX2PXy0WeJ5m0TN3+kFU2YgRCBsCK3Zgqsfp8bkObyJcPV
jIvinCFJugHZZgKdcsk4Ib6gga7VTNrpBKwj0ZfT7RV3xekaCjH/e2/uszMEYTh9
MkAbljgwd4WKopUtajjzFimDUP/q8i13LkXlRI1BV07b+lq2rAxYsSlRYlV+rvK/
Z+sEcMQdferRbT5kRa2yPzPMVBlK+PKZ6gqnkNUq9fhuLQpiJmTwzzUA0cL/uPeE
UpGxMYnMmXtdRdK+bZRZsZsHUTnTSnOzm3Ya8Y/ZE4OxwaE71RI2uuZVL0W7/RjG
NwBYH2bYG8Jzu5c/U5kRg2q3nFSYj09G1PwlR7pCwWp6+9tAsh91T4NR44USjrB9
0ULE+rSBZVCBHMpTDGxCuEr4ayMj3P4ogxFtEtYj4VnX+RELpyo=
=bsRV
-----END PGP SIGNATURE-----

--w2JjAQZceEVGylhD--